Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typeguard 4 might break things #137

Open
BSchilperoort opened this issue Jun 16, 2023 · 1 comment
Open

Typeguard 4 might break things #137

BSchilperoort opened this issue Jun 16, 2023 · 1 comment

Comments

@BSchilperoort
Copy link
Member

BSchilperoort commented Jun 16, 2023

Last month typeguard 4 was released. This introduces a lot of breaking changes.

See: https://typeguard.readthedocs.io/en/stable/versionhistory.html

@BSchilperoort BSchilperoort changed the title Typeguard 4 breaks things Typeguard 4 might break things Jun 16, 2023
@SarahAlidoost
Copy link
Member

SarahAlidoost commented Jul 5, 2023

cc @sverhoeven It actually breaks comparison environment with

grpc4bmi                  0.2.16                   pypi_0    pypi
typeguard                 4.0.0                    pypi_0    pypi

, see

---------------------------------------------------------------------------
ImportError                               Traceback (most recent call last)
Cell In[1], line 11
      9 import ewatercycle.config
     10 import ewatercycle.forcing
---> 11 import ewatercycle.models
     12 import ewatercycle.util
     13 import ewatercycle.parameter_sets

File /gpfs/home2/fakhereh/mambaforge-pypy3/envs/comparison/lib/python3.10/site-packages/ewatercycle/models/__init__.py:1
----> 1 from .hype import Hype
      2 from .lisflood import Lisflood
      3 from .marrmot import MarrmotM01, MarrmotM14

File /gpfs/home2/fakhereh/mambaforge-pypy3/envs/comparison/lib/python3.10/site-packages/ewatercycle/models/hype.py:13
     11 from dateutil.parser import parse
     12 from dateutil.tz import UTC
---> 13 from grpc4bmi.bmi_client_docker import BmiClientDocker
     14 from grpc4bmi.bmi_client_singularity import BmiClientSingularity
     16 from ewatercycle import CFG

File /gpfs/home2/fakhereh/mambaforge-pypy3/envs/comparison/lib/python3.10/site-packages/grpc4bmi/bmi_client_docker.py:7
      4 from typing import Iterable
      6 import docker
----> 7 from typeguard import check_argument_types, qualified_name
      9 from grpc4bmi.bmi_grpc_client import BmiClient
     10 from grpc4bmi.exceptions import DeadContainerException

ImportError: cannot import name 'check_argument_types' from 'typeguard' (/gpfs/home2/fakhereh/mambaforge-pypy3/envs/comparison/lib/python3.10/site-packages/typeguard/__init__.py)

check_argument_types() wss removed in 3.0.0 (2023-03-15).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants