Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle grid type scalar #143

Open
sverhoeven opened this issue Sep 18, 2023 · 0 comments
Open

handle grid type scalar #143

sverhoeven opened this issue Sep 18, 2023 · 0 comments

Comments

@sverhoeven
Copy link
Member

In

if model_type in {'uniform_rectilinear', 'rectilinear'}:
we now handle 'uniform_rectilinear', 'rectilinear', but there is also 'scalar' (https://bmi.readthedocs.io/en/stable/#get-grid-type).

Scalar looks like the right type to use for lumped models.

A lumped model might not even know where (geographically) is is being run.

We should figure out what the get_grid_* functions should return for a model with get_grid_type=='scalar'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant