Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MemoizedBmi has incorrect set_value_at_indices kwarg #155

Open
BSchilperoort opened this issue Dec 5, 2024 · 0 comments
Open

MemoizedBmi has incorrect set_value_at_indices kwarg #155

BSchilperoort opened this issue Dec 5, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@BSchilperoort
Copy link
Member

MemoizedBmi has the following method set_value_at_indices

    def set_value_at_indices(self, var_name, indices, src):
        return self.origin.set_value_at_indices(var_name, indices, src)

However, the BMI spec (and the OptionalDestBmi & BmiClient) has the following method signature:

    def set_value_at_indices(self, name, inds, src):

If a user uses kwargs with the memoized bmi this will go wrong.

@BSchilperoort BSchilperoort added the bug Something isn't working label Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant