diff --git a/flyteadmin/boilerplate/lyft/golang_support_tools/tools.go b/flyteadmin/boilerplate/lyft/golang_support_tools/tools.go index 88ff645233..4310b39d79 100644 --- a/flyteadmin/boilerplate/lyft/golang_support_tools/tools.go +++ b/flyteadmin/boilerplate/lyft/golang_support_tools/tools.go @@ -3,8 +3,8 @@ package tools import ( - _ "github.com/alvaroloes/enumer" _ "github.com/golangci/golangci-lint/cmd/golangci-lint" _ "github.com/lyft/flytestdlib/cli/pflags" _ "github.com/vektra/mockery/cmd/mockery" + _ "github.com/alvaroloes/enumer" ) diff --git a/flyteadmin/boilerplate/lyft/pull_request_template/Readme.rst b/flyteadmin/boilerplate/lyft/pull_request_template/Readme.rst new file mode 100644 index 0000000000..b85a4ea121 --- /dev/null +++ b/flyteadmin/boilerplate/lyft/pull_request_template/Readme.rst @@ -0,0 +1,8 @@ +Pull Request Template +~~~~~~~~~~~~~~~~~~~~~ + +Provides a Pull Request template. + +**To Enable:** + +Add ``lyft/golang_test_targets`` to your ``boilerplate/update.cfg`` file. diff --git a/flyteadmin/boilerplate/lyft/pull_request_template/pull_request_template.md b/flyteadmin/boilerplate/lyft/pull_request_template/pull_request_template.md new file mode 100644 index 0000000000..d2becf38b7 --- /dev/null +++ b/flyteadmin/boilerplate/lyft/pull_request_template/pull_request_template.md @@ -0,0 +1,26 @@ +# TL;DR +_Please replace this text with a description of what this PR accomplishes._ + +## Type + - [ ] Bug Fix + - [ ] Feature + - [ ] Plugin + +## Are all requirements met? + + - [ ] Code completed + - [ ] Smoke tested + - [ ] Unit tests added + - [ ] Code documentation added + - [ ] Any pending items have an associated Issue + +## Complete description + _How did you fix the bug, make the feature etc. Link to any design docs etc_ + +## Tracking Issue +https://github.com/lyft/flyte/issues/ + +## Follow-up issue +_NA_ +OR +_https://github.com/lyft/flyte/issues/_ diff --git a/flyteadmin/boilerplate/lyft/pull_request_template/update.sh b/flyteadmin/boilerplate/lyft/pull_request_template/update.sh new file mode 100755 index 0000000000..13f0c3b57d --- /dev/null +++ b/flyteadmin/boilerplate/lyft/pull_request_template/update.sh @@ -0,0 +1,12 @@ +#!/usr/bin/env bash + +# WARNING: THIS FILE IS MANAGED IN THE 'BOILERPLATE' REPO AND COPIED TO OTHER REPOSITORIES. +# ONLY EDIT THIS FILE FROM WITHIN THE 'LYFT/BOILERPLATE' REPOSITORY: +# +# TO OPT OUT OF UPDATES, SEE https://github.com/lyft/boilerplate/blob/master/Readme.rst + +set -e + +DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null && pwd )" + +cp ${DIR}/pull_request_template.md ${DIR}/../../../pull_request_template.md diff --git a/flyteadmin/boilerplate/update.cfg b/flyteadmin/boilerplate/update.cfg index 21789a4d78..7b6d9b688e 100644 --- a/flyteadmin/boilerplate/update.cfg +++ b/flyteadmin/boilerplate/update.cfg @@ -2,3 +2,4 @@ lyft/docker_build lyft/golang_test_targets lyft/golang_dockerfile lyft/golang_support_tools +lyft/pull_request_template diff --git a/flyteadmin/pull_request_template.md b/flyteadmin/pull_request_template.md new file mode 100644 index 0000000000..d2becf38b7 --- /dev/null +++ b/flyteadmin/pull_request_template.md @@ -0,0 +1,26 @@ +# TL;DR +_Please replace this text with a description of what this PR accomplishes._ + +## Type + - [ ] Bug Fix + - [ ] Feature + - [ ] Plugin + +## Are all requirements met? + + - [ ] Code completed + - [ ] Smoke tested + - [ ] Unit tests added + - [ ] Code documentation added + - [ ] Any pending items have an associated Issue + +## Complete description + _How did you fix the bug, make the feature etc. Link to any design docs etc_ + +## Tracking Issue +https://github.com/lyft/flyte/issues/ + +## Follow-up issue +_NA_ +OR +_https://github.com/lyft/flyte/issues/_