From 5981c35dbe2033e9905283c4ea4b667e79f0bf8b Mon Sep 17 00:00:00 2001 From: bstadlbauer <11799671+bstadlbauer@users.noreply.github.com> Date: Mon, 13 Feb 2023 16:46:27 +0100 Subject: [PATCH] Rename dask port from to (#315) Signed-off-by: Bernhard Stadlbauer Signed-off-by: Bernhard Stadlbauer <11799671+bstadlbauer@users.noreply.github.com> --- go/tasks/plugins/k8s/dask/dask.go | 6 +++--- go/tasks/plugins/k8s/dask/dask_test.go | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/go/tasks/plugins/k8s/dask/dask.go b/go/tasks/plugins/k8s/dask/dask.go index 610bb7bc56..aa820bce38 100755 --- a/go/tasks/plugins/k8s/dask/dask.go +++ b/go/tasks/plugins/k8s/dask/dask.go @@ -247,7 +247,7 @@ func createSchedulerSpec(cluster plugins.DaskScheduler, clusterName string, defa Env: defaults.Env, Ports: []v1.ContainerPort{ { - Name: "comm", + Name: "tcp-comm", ContainerPort: 8786, Protocol: "TCP", }, @@ -268,10 +268,10 @@ func createSchedulerSpec(cluster plugins.DaskScheduler, clusterName string, defa }, Ports: []v1.ServicePort{ { - Name: "comm", + Name: "tcp-comm", Protocol: "TCP", Port: 8786, - TargetPort: intstr.FromString("comm"), + TargetPort: intstr.FromString("tcp-comm"), }, { Name: "dashboard", diff --git a/go/tasks/plugins/k8s/dask/dask_test.go b/go/tasks/plugins/k8s/dask/dask_test.go index 054f23c1e2..2eb36ad3b9 100644 --- a/go/tasks/plugins/k8s/dask/dask_test.go +++ b/go/tasks/plugins/k8s/dask/dask_test.go @@ -213,7 +213,7 @@ func TestBuildResourceDaskHappyPath(t *testing.T) { schedulerSpec := daskJob.Spec.Cluster.Spec.Scheduler.Spec expectedPorts := []v1.ContainerPort{ { - Name: "comm", + Name: "tcp-comm", ContainerPort: 8786, Protocol: "TCP", }, @@ -240,10 +240,10 @@ func TestBuildResourceDaskHappyPath(t *testing.T) { } expectedSerivcePorts := []v1.ServicePort{ { - Name: "comm", + Name: "tcp-comm", Protocol: "TCP", Port: 8786, - TargetPort: intstr.FromString("comm"), + TargetPort: intstr.FromString("tcp-comm"), }, { Name: "dashboard",