Support active user calculation for self-hosted repos #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This dynamically adds SSH keys based on the URL passed, allowing clones to work with providers other than github and gitlab.
rrjjvv
force-pushed
the
hosted-active-users
branch
from
d0881e0 to
5ebf22f
Compare
|
Thanks Roberto! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This dynamically adds SSH keys based on the URL passed, allowing clones to work with providers other than github and gitlab.
This was surprisingly complicated; I believe the combination of the entire URL being passed as a secret, which necessitates
--no-cache, resulted in my preferred implementations not working (I suspect due to earthly/earthly#2593). I assumed keeping the 'interface' intact was paramount (given that it's publicly documented); inlining all usage of the secret was the only thing that worked consistently.You're welcome to close this, borrow from it for your own preferred implementation, etc. I at least wanted it to work for myself, so figured I'd share it.
Potential fix for #49