Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_isnanf on Windows instead of isnanf #185

Closed
vtorri opened this issue May 31, 2020 · 2 comments
Closed

_isnanf on Windows instead of isnanf #185

vtorri opened this issue May 31, 2020 · 2 comments

Comments

@vtorri
Copy link
Contributor

vtorri commented May 31, 2020

in src/graphene-ray.c, isnanf does not exist on Windows, but _isnanf does :

https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/isnan-isnan-isnanf?view=vs-2019

would it be possible do something like

#if defined _WIN32 && ! defined isnanf
# define isnanf(x) _isnanf(x)
#endif

at the top of graphene-ray.c for example ?

then maybe the check os isnanf in meson.buikd on Windows is useless

thank you

@vtorri
Copy link
Contributor Author

vtorri commented May 31, 2020

also, one should define HAVE_ISNANF in it. So

#if defined _WIN32 && ! defined isnanf
# define isnanf(x) _isnanf(x)
# define HAVE_ISNANF
#endif

@ebassi
Copy link
Owner

ebassi commented Jun 18, 2020

Thanks for your patience.

Would you care to put together a merge request?

@ebassi ebassi closed this as completed Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants