Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Box tests fail on QNX 8.0 and 7.0 #278

Open
fxing-qnx opened this issue Jan 22, 2025 · 0 comments · May be fixed by #277
Open

Box tests fail on QNX 8.0 and 7.0 #278

fxing-qnx opened this issue Jan 22, 2025 · 0 comments · May be fixed by #277

Comments

@fxing-qnx
Copy link

fxing-qnx commented Jan 22, 2025

Mirror of #277 requested by the contribution requirement. I am sorry for having this issue late.

Fixes # N/A
Proposed changes: Replace isinff(...) with a combination of isinf(...) and signbit(...)
Benchmark results: No changes in performance.
Test suite changes: N/A
Almost the same to #188, but more aggressive. isinff(...) is completely remove from the source tree.
Reason: Mentioned in PR188, isinff(...) is both obsolete and non-standard. To maximize portability and suggested by GNU, we should have it replaced.
PS, Sorry due to our process we need to always fork under tags even if a tag only contains version changes. I have a rebased branch ready for merge now.

Test failed:

box(empty).center() to be in (0, 0, 0) FAIL

The test fails because isinff(...) is used; it is non-standard and obsolete (by GNU), it has different behaviors on QNX compared to Linux.

@fxing-qnx fxing-qnx linked a pull request Jan 22, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant