Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workspaces default editor and components #567

Merged
merged 7 commits into from
Jun 27, 2022
Merged

Add workspaces default editor and components #567

merged 7 commits into from
Jun 27, 2022

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Jun 24, 2022

What does this PR do?

Add workspaces default editor and component.

What issues does this PR fix or reference?

fixes eclipse-che/che#21353
fixes eclipse-che/che#21502

Is it tested? How?

  1. Deploy Eclipse Che with this image: quay.io/eclipse/che-dashboard:pr-567
  2. Add defaults(patch checluster/eclipse-che). For example:
  devEnvironments:
    defaultComponents:
      - container:
          image: 'quay.io/devfile/universal-developer-image:ubi8-latest'
          sourceMapping: /projects
        name: universal-developer-image
    defaultEditor: eclipse/theia/next
  1. Create a workspace using a GitHub repository without a devfile.
    For example: https://github.com/eclipse-che/che-jwtproxy
  2. You should be able to see all default components propagated to the workspace

Знімок екрана 2022-06-24 о 20 27 15

You can test it with https://eclipse-che.apps.cluster-5s2x5.5s2x5.sandbox995.opentlc.com

@olexii4 olexii4 requested a review from akurinnoy as a code owner June 24, 2022 13:54
@che-bot
Copy link
Contributor

che-bot commented Jun 24, 2022

Click here to review and test in web IDE: Contribute

1 similar comment
@che-bot
Copy link
Contributor

che-bot commented Jun 24, 2022

Click here to review and test in web IDE: Contribute

@che-bot
Copy link
Contributor

che-bot commented Jun 24, 2022

Click here to review and test in web IDE: Contribute

@che-bot
Copy link
Contributor

che-bot commented Jun 24, 2022

Click here to review and test in web IDE: Contribute

@ibuziuk ibuziuk self-requested a review June 24, 2022 14:16
@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-567

1 similar comment
@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-567

@openshift-ci
Copy link

openshift-ci bot commented Jun 24, 2022

@olexii4: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v8-dashboard-happy-path e3087ad link true /test v8-dashboard-happy-path

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@che-bot
Copy link
Contributor

che-bot commented Jun 27, 2022

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-567

@che-bot
Copy link
Contributor

che-bot commented Jun 27, 2022

Click here to review and test in web IDE: Contribute

@che-bot
Copy link
Contributor

che-bot commented Jun 27, 2022

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-567

@che-bot
Copy link
Contributor

che-bot commented Jun 27, 2022

Click here to review and test in web IDE: Contribute

Copy link
Member

@ibuziuk ibuziuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job 👍

@che-bot
Copy link
Contributor

che-bot commented Jun 27, 2022

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-567

Copy link
Contributor

@akurinnoy akurinnoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link

openshift-ci bot commented Jun 27, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, ibuziuk, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-567

@olexii4 olexii4 merged commit 6132d4e into main Jun 27, 2022
@olexii4 olexii4 deleted the CHE-21353 branch June 27, 2022 14:01
@che-bot che-bot added this to the 7.50 milestone Jun 27, 2022
@olexii4 olexii4 changed the title Add workspaces default editor and component Add workspaces default editor and components Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants