-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workspaces default editor and components #567
Conversation
Signed-off-by: Oleksii Orel <[email protected]>
1 similar comment
Signed-off-by: Oleksii Orel <[email protected]>
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-567 |
1 similar comment
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-567 |
@olexii4: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-567 |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-567 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great job 👍
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-567 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, ibuziuk, olexii4 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-567 |
What does this PR do?
Add workspaces default editor and component.
What issues does this PR fix or reference?
fixes eclipse-che/che#21353
fixes eclipse-che/che#21502
Is it tested? How?
quay.io/eclipse/che-dashboard:pr-567
For example:
https://github.com/eclipse-che/che-jwtproxy
You can test it with https://eclipse-che.apps.cluster-5s2x5.5s2x5.sandbox995.opentlc.com