-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update uninstallation guide #2281
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
16 tasks
dkwon17
commented
Apr 11, 2022
$ oc delete devworkspaceroutings.controller.devfile.io --all-namespaces --all --wait | ||
---- | ||
|
||
pass:[<!-- vale RedHat.Spelling = NO -->] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added this to ignore this warning:
modules/administration-guide/pages/uninstalling-che-after-operatorhub-installation.adoc
51:31 warning Use correct American English RedHat.Spelling
spelling. Did you really mean
'finalizers'?
ibuziuk
approved these changes
Apr 13, 2022
I am reviewing this PR. |
Signed-off-by: David Kwon <[email protected]>
max-cx
reviewed
Apr 21, 2022
Co-authored-by: Max Leonov <[email protected]>
I opened dkwon17#8 for my review. |
review: Uninstall
Signed-off-by: dakwon <[email protected]>
max-cx
reviewed
Apr 26, 2022
modules/administration-guide/pages/uninstalling-che-by-using-chectl.adoc
Outdated
Show resolved
Hide resolved
…hectl.adoc Co-authored-by: Max Leonov <[email protected]>
max-cx
reviewed
Apr 26, 2022
modules/administration-guide/pages/uninstalling-che-by-using-chectl.adoc
Outdated
Show resolved
Hide resolved
…hectl.adoc Co-authored-by: Max Leonov <[email protected]>
max-cx
reviewed
Apr 26, 2022
modules/administration-guide/pages/uninstalling-che-by-using-chectl.adoc
Outdated
Show resolved
Hide resolved
…hectl.adoc Co-authored-by: Max Leonov <[email protected]>
Signed-off-by: dakwon <[email protected]>
max-cx
added a commit
to max-cx/che-docs
that referenced
this pull request
Apr 28, 2022
* docs: update uninstallation guide Signed-off-by: David Kwon <[email protected]> * draft * Update modules/administration-guide/pages/uninstalling-che.adoc Co-authored-by: Max Leonov <[email protected]> * review * discussed changes * Remove dex namespace Signed-off-by: dakwon <[email protected]> * Update modules/administration-guide/pages/uninstalling-che-by-using-chectl.adoc Co-authored-by: Max Leonov <[email protected]> * Update modules/administration-guide/pages/uninstalling-che-by-using-chectl.adoc Co-authored-by: Max Leonov <[email protected]> * review * Update modules/administration-guide/pages/uninstalling-che-by-using-chectl.adoc Co-authored-by: Max Leonov <[email protected]> * Rename file Signed-off-by: dakwon <[email protected]> Co-authored-by: Max Leonov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: David Kwon [email protected]
This PR updates the uninstallation guide.
What does this pull request change
Before:
After:
The PR also adds instructions to uninstall the DevWorkspace Operator resources before uninstalling Che. Those instructions originally come from: https://docs.openshift.com/container-platform/4.8/web_console/odc-about-web-terminal.html#deleting-the-devworkspace-operator-dependency
What issues does this pull request fix or reference
eclipse-che/che#21284
Specify the version of the product this pull request applies to
Pull request checklist
The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.
Validate language on files added or modified
step reports no vale warnings.