Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update uninstallation guide #2281

Merged
merged 14 commits into from
Apr 26, 2022
Merged

Conversation

dkwon17
Copy link
Contributor

@dkwon17 dkwon17 commented Apr 11, 2022

Signed-off-by: David Kwon [email protected]

This PR updates the uninstallation guide.

What does this pull request change

Before:
image

After:
image

The PR also adds instructions to uninstall the DevWorkspace Operator resources before uninstalling Che. Those instructions originally come from: https://docs.openshift.com/container-platform/4.8/web_console/odc-about-web-terminal.html#deleting-the-devworkspace-operator-dependency

What issues does this pull request fix or reference

eclipse-che/che#21284

Specify the version of the product this pull request applies to

Pull request checklist

The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.

  • Any procedure:
    • Successfully tested.
  • Any page or link rename:
  • Builds on Eclipse Che hosted by Red Hat.
  • the Validate language on files added or modified step reports no vale warnings.

@dkwon17 dkwon17 requested review from rkratky and themr0c as code owners April 11, 2022 18:12
@github-actions
Copy link

Click here to review and test in web IDE: Contribute

$ oc delete devworkspaceroutings.controller.devfile.io --all-namespaces --all --wait
----

pass:[<!-- vale RedHat.Spelling = NO -->]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added this to ignore this warning:

 modules/administration-guide/pages/uninstalling-che-after-operatorhub-installation.adoc
 51:31  warning  Use correct American English    RedHat.Spelling 
                 spelling. Did you really mean                   
                 'finalizers'? 

@themr0c themr0c added this to the 7.46 milestone Apr 15, 2022
@max-cx
Copy link
Contributor

max-cx commented Apr 19, 2022

I am reviewing this PR.

@max-cx max-cx mentioned this pull request Apr 23, 2022
6 tasks
@max-cx
Copy link
Contributor

max-cx commented Apr 23, 2022

I opened dkwon17#8 for my review.

@dkwon17 dkwon17 merged commit 6bce067 into eclipse-che:master Apr 26, 2022
max-cx added a commit to max-cx/che-docs that referenced this pull request Apr 28, 2022
* docs: update uninstallation guide

Signed-off-by: David Kwon <[email protected]>

* draft

* Update modules/administration-guide/pages/uninstalling-che.adoc

Co-authored-by: Max Leonov <[email protected]>

* review

* discussed changes

* Remove dex namespace

Signed-off-by: dakwon <[email protected]>

* Update modules/administration-guide/pages/uninstalling-che-by-using-chectl.adoc

Co-authored-by: Max Leonov <[email protected]>

* Update modules/administration-guide/pages/uninstalling-che-by-using-chectl.adoc

Co-authored-by: Max Leonov <[email protected]>

* review

* Update modules/administration-guide/pages/uninstalling-che-by-using-chectl.adoc

Co-authored-by: Max Leonov <[email protected]>

* Rename file

Signed-off-by: dakwon <[email protected]>

Co-authored-by: Max Leonov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants