Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused properties update from release script #442

Closed
wants to merge 1 commit into from
Closed

chore: remove unused properties update from release script #442

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions make-release.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,11 +228,6 @@ prepareRelease() {
echo "[INFO] Dependencies updated in che typescript DTO (parent = ${VERSION_CHE_PARENT}, che server = ${CHE_VERSION})"
popd >/dev/null

# TODO more elegant way to execute these scripts
pushd .ci >/dev/null
./set_tag_version_images.sh ${CHE_VERSION}
echo "[INFO] Tag versions of images have been set in che-server"
popd >/dev/null
# run mvn license format, in case some files that have old license headers have been updated
mvn license:format
popd >/dev/null
Expand Down Expand Up @@ -403,20 +398,6 @@ bumpVersion() {
set +x
}

updateImageTagsInCheServer() {
pushd che-server >/dev/null
git checkout ${BRANCH}
plugin_version="latest"
sed_in_place -r -e "s#che.factory.default_editor=eclipse/che-theia/.*#che.factory.default_editor=eclipse/che-theia/$plugin_version#g" assembly/assembly-wsmaster-war/src/main/webapp/WEB-INF/classes/che/che.properties
sed_in_place -r -e "s#che.workspace.devfile.default_editor=eclipse/che-theia/.*#che.workspace.devfile.default_editor=eclipse/che-theia/$plugin_version#g" assembly/assembly-wsmaster-war/src/main/webapp/WEB-INF/classes/che/che.properties

if [[ $(git diff --stat) != '' ]]; then
git commit -asm "chore: Set ${CHE_VERSION} release image tags"
git push origin ${BRANCH}
fi
popd >/dev/null
}

installMaven
loadMvnSettingsGpgKey
installDebDeps
Expand All @@ -429,7 +410,6 @@ checkoutProjects

if [[ "${BUMP_NEXT_VERSION}" = "true" ]]; then
bumpVersions
updateImageTagsInCheServer
# checkout back to branches to make release from
checkoutProjects
fi
Expand Down