Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

chore: Pin che-theia to the upstream Theia commit #1205

Merged
merged 2 commits into from
Aug 31, 2021

Conversation

RomanNikitenko
Copy link
Member

@RomanNikitenko RomanNikitenko commented Aug 31, 2021

Signed-off-by: Roman Nikitenko [email protected]

What does this PR do?

Pin che-theia to the upstream Theia commit before breaking changes.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

eclipse-che/che#20366

How to test this PR?

There are 2 breaking changes in the upstream:

extensions_activation

So, starting a workspace, the editor and activation of the extensions should be checked with these changes.

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Happy Path Channel

HAPPY_PATH_CHANNEL=stable

@codecov
Copy link

codecov bot commented Aug 31, 2021

Codecov Report

Merging #1205 (fcbb6df) into main (c299f59) will decrease coverage by 0.26%.
The diff coverage is 13.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1205      +/-   ##
==========================================
- Coverage   32.78%   32.52%   -0.27%     
==========================================
  Files         290      295       +5     
  Lines        9885     9980      +95     
  Branches     1457     1469      +12     
==========================================
+ Hits         3241     3246       +5     
- Misses       6641     6731      +90     
  Partials        3        3              
Impacted Files Coverage Δ
...theia-about/src/browser/about-che-theia-dialog.tsx 0.00% <0.00%> (ø)
...credentials/src/browser/che-credentials-service.ts 0.00% <0.00%> (ø)
...entials/src/browser/credentials-frontend-module.ts 0.00% <0.00%> (ø)
...eia-credentials/src/common/credentials-protocol.ts 0.00% <0.00%> (ø)
...eia-credentials/src/node/che-credentials-server.ts 0.00% <0.00%> (ø)
...s/src/node/che-theia-credentials-backend-module.ts 0.00% <0.00%> (ø)
...rowser/src/browser/che-mini-browser-environment.ts 0.00% <0.00%> (ø)
...he-server/src/node/che-server-http-service-impl.ts 0.00% <0.00%> (ø)
...-che-server/src/node/che-server-remote-api-impl.ts 38.88% <0.00%> (ø)
...browser/contribution/exec-terminal-contribution.ts 0.00% <0.00%> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ad19a3...fcbb6df. Read the comment docs.

@che-bot

This comment has been minimized.

@RomanNikitenko

This comment has been minimized.

@che-bot

This comment has been minimized.

@che-bot
Copy link
Contributor

che-bot commented Aug 31, 2021

✅ E2E Happy path tests succeed 🎉

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia quay.io/crw_pr/che-theia:1205
che-theia-endpoint-runtime-binary quay.io/crw_pr/che-theia-endpoint-runtime-binary:1205

Test product:

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

@RomanNikitenko RomanNikitenko marked this pull request as ready for review August 31, 2021 14:35
@azatsarynnyy
Copy link
Member

So, is it ready to merge?

@vitaliy-guliy
Copy link
Contributor

Please ensure, that java plugin is working properly
eclipse-che/che#20360

@vitaliy-guliy
Copy link
Contributor

Let's use the same commit, as it used in che-theia 7.35.1 https://github.com/eclipse-che/che-theia/blob/7.35.1/build.include#L17
You are referring to a commit, that is one day older.

@RomanNikitenko
Copy link
Member Author

RomanNikitenko commented Aug 31, 2021

Please ensure, that java plugin is working properly
eclipse-che/che#20360

With these changes I started a workspace successfully
Screenshot 2021-08-31 at 18 09 53

The devfile is:

apiVersion: 1.0.0
metadata:
  name: minimal-workspace
projects:
  - name: web-java-spring-petclinic
    source:
      location: 'https://github.com/che-samples/java-spring-petclinic'
      type: git
components:
  - type: cheEditor
    reference: 'https://raw.githubusercontent.com/chepullreq4/pr-check-files/master/che-theia/pr-1205/simple/che-theia-editor.yaml'
  - id: redhat/java8/latest
    type: chePlugin

So, I'm going to merge the PR ASAP

@RomanNikitenko
Copy link
Member Author

RomanNikitenko commented Aug 31, 2021

You are referring to a commit, that is one day older.

are you sure about that?

@vitaliy-guliy
Copy link
Contributor

You are referring to a commit, that is one day older.

are you sure about that?

You are right. A commit, that I mentioned, is already 13 days old.

@RomanNikitenko RomanNikitenko merged commit 81b2e3a into eclipse-che:main Aug 31, 2021
@RomanNikitenko RomanNikitenko deleted the pinTheiaCommit branch August 31, 2021 15:25
@che-bot che-bot added this to the 7.36 milestone Aug 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants