-
Notifications
You must be signed in to change notification settings - Fork 111
chore: Pin che-theia to the upstream Theia commit #1205
chore: Pin che-theia to the upstream Theia commit #1205
Conversation
Signed-off-by: Roman Nikitenko <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1205 +/- ##
==========================================
- Coverage 32.78% 32.52% -0.27%
==========================================
Files 290 295 +5
Lines 9885 9980 +95
Branches 1457 1469 +12
==========================================
+ Hits 3241 3246 +5
- Misses 6641 6731 +90
Partials 3 3
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Roman Nikitenko <[email protected]>
✅ E2E Happy path tests succeed 🎉 See Details
Test product:
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
So, is it ready to merge? |
Please ensure, that java plugin is working properly |
Let's use the same commit, as it used in che-theia 7.35.1 https://github.com/eclipse-che/che-theia/blob/7.35.1/build.include#L17 |
With these changes I started a workspace successfully The devfile is:
So, I'm going to merge the PR ASAP |
are you sure about that? |
You are right. A commit, that I mentioned, is already 13 days old. |
Signed-off-by: Roman Nikitenko [email protected]
What does this PR do?
Pin
che-theia
to the upstreamTheia
commit before breaking changes.Screenshot/screencast of this PR
What issues does this PR fix or reference?
eclipse-che/che#20366
How to test this PR?
There are 2 breaking changes in the upstream:
Language Support for Java(TM) by Red Hat
andDebugger for Java
):So, starting a workspace, the editor and activation of the extensions should be checked with these changes.
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.
Happy Path Channel
HAPPY_PATH_CHANNEL=stable