Align che-theia with upstream changes #1213

RomanNikitenko · 2021-09-03T08:30:36Z

What does this PR do?

Moves che-theia to ES2017.
Provides adaptation to upstream changes.
Pin che-theia to theia commit before new breaking change (eclipse-theia/theia@23e09c2). Adaption for those changes will be provided within a separate PR.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

eclipse-che/che#20366
eclipse-che/che#20360

How to test this PR?

the PR fixes deploy of remote plugins, please see Steps to reproduce here
activation of VS Code extensions should be fixed, please see the comment here.
all other functionality should work as before breaking changes in upstream.

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Happy Path Channel

HAPPY_PATH_CHANNEL=stable

codecov · 2021-09-03T08:44:49Z

Codecov Report

Merging #1213 (89c29ab) into main (c299f59) will decrease coverage by 1.50%.
The diff coverage is 18.14%.

@@            Coverage Diff             @@
##             main    #1213      +/-   ##
==========================================
- Coverage   32.78%   31.28%   -1.51%     
==========================================
  Files         290      296       +6     
  Lines        9885     9826      -59     
  Branches     1457     1316     -141     
==========================================
- Hits         3241     3074     -167     
- Misses       6641     6749     +108     
  Partials        3        3

Impacted Files	Coverage Δ
...theia-about/src/browser/about-che-theia-dialog.tsx	`0.00% <0.00%> (ø)`
...credentials/src/browser/che-credentials-service.ts	`0.00% <0.00%> (ø)`
...entials/src/browser/credentials-frontend-module.ts	`0.00% <0.00%> (ø)`
...eia-credentials/src/common/credentials-protocol.ts	`0.00% <0.00%> (ø)`
...eia-credentials/src/node/che-credentials-server.ts	`0.00% <0.00%> (ø)`
...s/src/node/che-theia-credentials-backend-module.ts	`0.00% <0.00%> (ø)`
...rowser/src/browser/che-mini-browser-environment.ts	`0.00% <0.00%> (ø)`
...ia-plugin-remote/src/node/hosted-plugin-service.ts	`0.00% <0.00%> (ø)`
...in-remote/src/node/plugin-remote-backend-module.ts	`0.00% <0.00%> (ø)`
...theia-plugin-remote/src/node/plugin-remote-init.ts	`0.00% <0.00%> (ø)`
... and 207 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f85127c...89c29ab. Read the comment docs.

RomanNikitenko · 2021-09-03T14:10:38Z

The changes fix errors from eclipse-che/che#20366, but there are still problems related to plugins, so I'm investigating eclipse-che/che#20360

tsmaeder · 2021-09-07T09:05:37Z

plugins/recommendations-plugin/tsconfig.json

@@ -1,6 +1,6 @@
 {
    "compilerOptions": {
-      "target": "es6",
+      "target": "ES2017",


We should really align the compiler options with the other plugins, in particular add "extends": "../../configs/base.tsconfig", There will be some errors compiling, but they are easily fixed.

thanks Florent it was done within #1215

tsmaeder · 2021-09-07T09:07:32Z

extensions/che-theia-hosted-plugin-manager-extension/tsconfig.json

@@ -2,7 +2,7 @@
    "extends": "../../configs/base.tsconfig.json",
    "compilerOptions": {
        "lib": [
-            "es6",
+            "ES2017",


Since this is the default in base.tsconfig.json, I believe we can remove the "lib" option here. it would make future updates easier.

tools/automation/tsconfig.json

che-bot · 2021-09-24T05:47:56Z

✅ E2E Happy path tests succeed 🎉

See Details

name	link
che-theia	quay.io/crw_pr/che-theia:1213
che-theia-endpoint-runtime-binary	quay.io/crw_pr/che-theia-endpoint-runtime-binary:1213

Test product:

tested with Eclipse Che on K8S (minikube v1.22.0)
E2E test scenario
E2E test pipeline source code

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

Signed-off-by: Roman Nikitenko <[email protected]>

…ions of vscode extensions Signed-off-by: Roman Nikitenko <[email protected]>

Signed-off-by: Roman Nikitenko <[email protected]>

che-bot · 2021-09-24T06:39:06Z

✅ E2E Happy path tests succeed 🎉

See Details

name	link
che-theia	quay.io/crw_pr/che-theia:1213
che-theia-endpoint-runtime-binary	quay.io/crw_pr/che-theia-endpoint-runtime-binary:1213

Test product:

tested with Eclipse Che on K8S (minikube v1.22.0)
E2E test scenario
E2E test pipeline source code

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

Signed-off-by: Roman Nikitenko <[email protected]>

che-bot · 2021-09-24T08:23:51Z

✅ E2E Happy path tests succeed 🎉

See Details

name	link
che-theia	quay.io/crw_pr/che-theia:1213
che-theia-endpoint-runtime-binary	quay.io/crw_pr/che-theia-endpoint-runtime-binary:1213

Test product:

tested with Eclipse Che on K8S (minikube v1.22.0)
E2E test scenario
E2E test pipeline source code

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

azatsarynnyy

I'm approving it based on the passed HappyPath tests.

azatsarynnyy · 2021-09-24T10:39:09Z

I think it's better to merge it after the upcoming 7.37 release, as it brings a lot of new commits from upstream. Which potentially may cause some other runtime breakages.

azatsarynnyy · 2021-09-29T13:16:17Z

7.37.x has been already tagged https://github.com/eclipse-che/che-theia/tree/7.37.x
So, we're good to merge.

benoitf approved these changes Sep 3, 2021

View reviewed changes

This comment has been minimized.

Sign in to view

azatsarynnyy mentioned this pull request Sep 7, 2021

Align che-theia with upstream changes eclipse-che/che#20366

Closed

tsmaeder reviewed Sep 7, 2021

View reviewed changes

tools/automation/tsconfig.json Show resolved Hide resolved

benoitf mentioned this pull request Sep 7, 2021

chore(recommendations-plugin): Use upper tsconfig file #1215

Merged

10 tasks

RomanNikitenko force-pushed the es2017 branch from c107800 to b5dd6f3 Compare September 11, 2021 10:52

This comment has been minimized.

Sign in to view

RomanNikitenko mentioned this pull request Sep 17, 2021

che-theia fails with redhat/java8/latest plugin eclipse-che/che#20360

Closed

mtsmfm mentioned this pull request Sep 20, 2021

Add CancellationError eclipse-theia/theia#10035

Merged

1 task

RomanNikitenko force-pushed the es2017 branch from b5dd6f3 to 4d62570 Compare September 24, 2021 04:37

RomanNikitenko added 4 commits September 24, 2021 08:56

chore: Move che-theia to ES2017

189c1e9

Signed-off-by: Roman Nikitenko <[email protected]>

chore: Include plugin-vscode-init inside node_modules for initializat…

005effb

…ions of vscode extensions Signed-off-by: Roman Nikitenko <[email protected]>

chore: Do not localize plugins

178aec1

Signed-off-by: Roman Nikitenko <[email protected]>

chore: Pin che-theia to the upstream Theia commit

544dbc9

Signed-off-by: Roman Nikitenko <[email protected]>

RomanNikitenko force-pushed the es2017 branch from 336cf8b to 544dbc9 Compare September 24, 2021 05:58

chore: update yarn.lock file

89c29ab

Signed-off-by: Roman Nikitenko <[email protected]>

RomanNikitenko marked this pull request as ready for review September 24, 2021 08:30

RomanNikitenko requested review from azatsarynnyy, sunix, svor and vinokurig as code owners September 24, 2021 08:30

RomanNikitenko requested review from vitaliy-guliy and vzhukovs as code owners September 24, 2021 08:30

RomanNikitenko requested a review from benoitf September 24, 2021 08:30

benoitf approved these changes Sep 24, 2021

View reviewed changes

azatsarynnyy approved these changes Sep 24, 2021

View reviewed changes

azatsarynnyy mentioned this pull request Sep 27, 2021

Editors Sprint 207 eclipse-che/che#20446

Closed

RomanNikitenko merged commit 911c9e2 into eclipse-che:main Sep 29, 2021

RomanNikitenko deleted the es2017 branch September 29, 2021 13:24

che-bot added this to the 7.38 milestone Sep 29, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Align che-theia with upstream changes #1213

Align che-theia with upstream changes #1213

RomanNikitenko commented Sep 3, 2021 •

edited

Loading

codecov bot commented Sep 3, 2021 •

edited

Loading

This comment has been minimized.

RomanNikitenko commented Sep 3, 2021

tsmaeder Sep 7, 2021

RomanNikitenko Sep 10, 2021 •

edited

Loading

tsmaeder Sep 7, 2021

RomanNikitenko Sep 24, 2021

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

che-bot commented Sep 24, 2021

che-bot commented Sep 24, 2021

che-bot commented Sep 24, 2021

azatsarynnyy left a comment

azatsarynnyy commented Sep 24, 2021

azatsarynnyy commented Sep 29, 2021

Align che-theia with upstream changes #1213

Align che-theia with upstream changes #1213

Conversation

RomanNikitenko commented Sep 3, 2021 • edited Loading

What does this PR do?

Screenshot/screencast of this PR

What issues does this PR fix or reference?

How to test this PR?

PR Checklist

Reviewers

Happy Path Channel

codecov bot commented Sep 3, 2021 • edited Loading

Codecov Report

This comment has been minimized.

RomanNikitenko commented Sep 3, 2021

tsmaeder Sep 7, 2021

Choose a reason for hiding this comment

RomanNikitenko Sep 10, 2021 • edited Loading

Choose a reason for hiding this comment

tsmaeder Sep 7, 2021

Choose a reason for hiding this comment

RomanNikitenko Sep 24, 2021

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

che-bot commented Sep 24, 2021

che-bot commented Sep 24, 2021

che-bot commented Sep 24, 2021

azatsarynnyy left a comment

Choose a reason for hiding this comment

azatsarynnyy commented Sep 24, 2021

azatsarynnyy commented Sep 29, 2021

RomanNikitenko commented Sep 3, 2021 •

edited

Loading

codecov bot commented Sep 3, 2021 •

edited

Loading

RomanNikitenko Sep 10, 2021 •

edited

Loading