chore: faster build of docker images

[vitaliy-guliy]

Signed-off-by: Vitaliy Gulyy [email protected]

What does this PR do?

Removes pre-building of Che-Theia before building of docker images.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

No issue

How to test this PR?

• clone che-theia repository
• switch to this branch
• build images with build.sh

PR Checklist

As the author of this Pull Request I made sure that:

• The Eclipse Contributor Agreement is valid
• Code produced is complete
• Code builds without errors
• Tests are covering the bugfix
• The repository devfile is up to date and works
• Sections What issues does this PR fix or reference and How to test this PR completed
• Relevant user documentation updated
• Relevant contributing documentation updated
• CI/CD changes implemented, documented and communicated
• Optional Companion PR for updating the HappyPath tests is approved and ready to be merged

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Happy Path Channel

HAPPY_PATH_CHANNEL=stable

[che-bot]

❌ E2E Happy path tests failed ❗

See Details

• Jenkins job

• test report

• logs and configs

• Happy path tests DevFile

• images:

name	link
che-theia	quay.io/crw_pr/che-theia:1279
che-theia-endpoint-runtime-binary	quay.io/crw_pr/che-theia-endpoint-runtime-binary:1279

Test product:

• tested with Eclipse Che on K8S (minikube v1.22.0)
• E2E test scenario
• E2E test pipeline source code

• Use comment "[crw-ci-test]" to rerun happy path E2E test.
• Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

[codecov]

Codecov Report

Merging #1279 (8d933d5) into main (c299f59) will increase coverage by 3.57%.
The diff coverage is 44.28%.

@@            Coverage Diff             @@
##             main    #1279      +/-   ##
==========================================
+ Coverage   32.78%   36.36%   +3.57%     
==========================================
  Files         290      325      +35     
  Lines        9885    10574     +689     
  Branches     1457     1367      -90     
==========================================
+ Hits         3241     3845     +604     
- Misses       6641     6724      +83     
- Partials        3        5       +2     

Impacted Files	Coverage Δ
...theia-about/src/browser/about-che-theia-dialog.tsx	0.00% <0.00%> (ø)
...credentials/src/browser/che-credentials-service.ts	0.00% <0.00%> (ø)
...entials/src/browser/credentials-frontend-module.ts	0.00% <0.00%> (ø)
...eia-credentials/src/common/credentials-protocol.ts	0.00% <0.00%> (ø)
...eia-credentials/src/node/che-credentials-server.ts	0.00% <0.00%> (ø)
...s/src/node/che-theia-credentials-backend-module.ts	0.00% <0.00%> (ø)
...ashboard/src/browser/che-theia-dashboard-module.ts	0.00% <0.00%> (ø)
...ia-dashboard/src/browser/theia-dashboard-client.ts	0.00% <0.00%> (ø)
...rowser/src/browser/che-mini-browser-environment.ts	0.00% <0.00%> (ø)
...in-ext/src/browser/che-sidecar-file-system-main.ts	100.00% <ø> (ø)
... and 290 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6538c23...8d933d5. Read the comment docs.

[azatsarynnyy]

Building it with yarn allows failing faster when there's a compilation error. So, not to wait while it fails within a docker build.

[azatsarynnyy]

On the other hand, as we have a dedicated GH action for validating sources build, it's a good idea to get rid of it.

[azatsarynnyy]

Please, take care of the --root-yarn-opts parameter as well. Otherwise, we'll have the dead code.
See the details in the PR https://github.com/eclipse-che/che-theia/pull/725/files
Also, need to check ./build.sh --root-yarn-opts:--ignore-scripts calls.