This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Prevent overwriting the DevWorkspace in-cluster object by a flattened Devfile #1346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tened Devfile Signed-off-by: Artem Zatsarynnyi <[email protected]>
azatsarynnyy
changed the title
benoitf
approved these changes
May 3, 2022
Signed-off-by: Artem Zatsarynnyi <[email protected]>
Signed-off-by: Artem Zatsarynnyi <[email protected]>
Signed-off-by: Artem Zatsarynnyi <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1346 +/- ##
==========================================
+ Coverage 32.78% 36.58% +3.79%
==========================================
Files 290 330 +40
Lines 9885 11331 +1446
Branches 1457 1568 +111
==========================================
+ Hits 3241 4145 +904
- Misses 6641 7181 +540
- Partials 3 5 +2
Continue to review full report at Codecov.
|
azatsarynnyy
requested review from
vinokurig,
vitaliy-guliy and
svor
as code owners
azatsarynnyy
changed the title
azatsarynnyy
added a commit
that referenced
this pull request
May 9, 2022
… Devfile (#1346) * fix: prevent overwriting the DevWorkspace in-cluster object by a flattened Devfile Signed-off-by: Artem Zatsarynnyi <[email protected]>
10 tasks
azatsarynnyy
added a commit
that referenced
this pull request
May 9, 2022
… Devfile (#1346) (#1347) * fix: prevent overwriting the DevWorkspace in-cluster object by a flattened Devfile Signed-off-by: Artem Zatsarynnyi <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Artem Zatsarynnyi [email protected]
What does this PR do?
The PR fixes the problem of overwriting the DevWorkspace in-cluster object by a flattened Devfile
when adding/removing a project or changing a project's git configuration, e.g. adding another remote repository.
Screenshot/screencast of this PR
What issues does this PR fix or reference?
it's a quick fix for eclipse-che/che#21244
How to test this PR?
che-url/#https://github.com/azatsarynnyy/che-editor-testctrl+shift+ptoGit: Add Remote...and enter e.g.https://github.com/golang/example.gitPR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.
Happy Path Channel
HAPPY_PATH_CHANNEL=stable