Update a couple of built-in plugins #887

vitaliy-guliy · 2020-10-21T13:34:07Z

Signed-off-by: Vitaliy Gulyy [email protected]

What does this PR do?

For some built-in plugins switches to their latest versions

What issues does this PR fix or reference?

eclipse-che/che#17524

Happy Path Channel

HAPPY_PATH_CHANNEL=stable

che-bot · 2020-10-21T14:09:03Z

❌ E2E Happy path tests failed ❗

See Details

name	link
che-theia	docker.io/maxura/che-theia:887
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:887

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

ℹ️ Use comment "[crw-ci-test]" to rerun happy path E2E test.

che-bot · 2020-10-22T12:22:05Z

❌ E2E Happy path tests failed ❗

See Details

name	link
che-theia	docker.io/maxura/che-theia:887
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:887

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

ℹ️ Use comment "[crw-ci-test]" to rerun happy path E2E test.

benoitf · 2020-10-22T12:30:29Z

I thought git 1.50 was requiring some theia api changes: eclipse-theia/theia#8623

vitaliy-guliy · 2020-10-22T12:37:03Z

I thought git 1.50 was requiring some theia api changes: eclipse-theia/theia#8623

I don't know exactly about changes in the API. This PR could wait for @vinokurig review as he is an expert in git.

vitaliy-guliy · 2020-10-22T12:44:43Z

@benoitf extracting vscode-git to separate PR

che-bot · 2020-10-22T13:49:19Z

❌ E2E Happy path tests failed ❗

See Details

name	link
che-theia	docker.io/maxura/che-theia:887
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:887

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

ℹ️ Use comment "[crw-ci-test]" to rerun happy path E2E test.

benoitf · 2020-10-23T13:58:59Z

hi @vitaliy-guliy could you rebase your PR to try to see a green happy path ?

vitaliy-guliy · 2020-10-27T12:04:32Z

It seems something has changed for this repository, as the PR closes automatically when force-pushing to the branch.

Signed-off-by: Vitaliy Gulyy <[email protected]>

che-bot · 2020-10-27T12:31:10Z

❌ E2E Happy path tests failed ❗

See Details

name	link
che-theia	docker.io/maxura/che-theia:887
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:887

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

ℹ️

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

vitaliy-guliy · 2020-10-28T09:45:45Z

[crw-ci-test --rebuild]

che-bot · 2020-10-28T10:17:17Z

✅ E2E Happy path tests succeed 🎉

See Details

name	link
che-theia	docker.io/maxura/che-theia:887
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:887

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

benoitf

please merge after 7.21 tag

azatsarynnyy

I've checked HTML/CSS/JSON syntax highlighting works as expected.
Also, HTML/CSS autocompletion features are working well.
For GitHub, I've checked some basic functionality. Everything seems to works fine.

vinokurig · 2020-10-29T06:41:44Z

I thought git 1.50 was requiring some theia api changes: eclipse-theia/theia#8623

I don't know exactly about changes in the API. This PR could wait for @vinokurig review as he is an expert in git.

vscode.git-1.49.3 is the latest working version for che-theia so far.

Signed-off-by: Vitaliy Gulyy <[email protected]>

che-bot · 2020-11-02T09:51:13Z

❌ E2E Happy path tests failed ❗

See Details

name	link
che-theia	docker.io/maxura/che-theia:887
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:887

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

vitaliy-guliy · 2020-11-02T09:53:55Z

[crw-ci-test --rebuild]

che-bot · 2020-11-02T10:15:54Z

❌ E2E Happy path tests failed ❗

See Details

name	link
che-theia	docker.io/maxura/che-theia:887
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:887

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

vitaliy-guliy · 2020-11-02T10:25:22Z

[crw-ci-test --rebuild]

che-bot · 2020-11-02T10:48:16Z

❌ E2E Happy path tests failed ❗

See Details

name	link
che-theia	docker.io/maxura/che-theia:887
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:887

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

benoitf · 2020-11-02T13:10:35Z

@ericwill curious: why did you merge with invalid happy path tests ?
it may push an invalid che-theia image to next tag

ericwill · 2020-11-02T14:04:52Z

@ericwill curious: why did you merge with invalid happy path tests ?
it may push an invalid che-theia image to next tag

Is it a hard requirement? I saw there were no significant changes (rebase commit only) since the happy path tests last passed, so I merged.

benoitf · 2020-11-02T14:16:21Z

@ericwill yes it's like a pre-requisites
we hold merge when HP is failing to clearly resolve the issue.

ericwill · 2020-11-02T16:14:52Z

@ericwill yes it's like a pre-requisites
we hold merge when HP is failing to clearly resolve the issue.

But in this case HP is failing due to some infra/deployment issue, should we block PRs even in such a case?

benoitf · 2020-11-02T16:22:29Z

well each new build can pull upstream theia changes that breaks

azatsarynnyy · 2020-11-03T08:44:21Z

Is it a hard requirement?

Of course, passing HappyPath tests is a requirement.
Guys, if there's any exceptional situation, please get approval from QE team before merging a PR with the red HappyPath tests.

ericwill · 2020-11-03T12:48:27Z

Maybe I misunderstand, is Happy Path testing also doing some integration build/push?

azatsarynnyy · 2020-11-03T13:29:58Z

HappyPath testing builds the images with the PR changes included for testing purposes.
Then, after merging the PR, che-theia:next images are built and updated on quay registry.

This reverts commit 7f117fc.

Signed-off-by: Vitaliy Gulyy <[email protected]>

… as GH action); can't popd out of a folder if we never when in there in the first place (#887) * work in tmp dir if --use-tmp-dir (not required when running as GH action) Change-Id: I59648ff7156bdce3f5361ea8e18df367eeebb924 Signed-off-by: nickboldt <[email protected]> * can't popd out of a folder if we never when in there in the first place Change-Id: I8d7bfa5df73bb9b561380b34cd90510686fc5369 Signed-off-by: nickboldt <[email protected]>

vitaliy-guliy marked this pull request as ready for review October 22, 2020 11:13

vitaliy-guliy requested review from azatsarynnyy, benoitf, RomanNikitenko and vzhukovs as code owners October 22, 2020 11:13

vitaliy-guliy closed this Oct 27, 2020

vitaliy-guliy force-pushed the builtin-plugins branch from f80468e to 9e1de13 Compare October 27, 2020 12:01

Upate some plugins

2e27b81

Signed-off-by: Vitaliy Gulyy <[email protected]>

vitaliy-guliy reopened this Oct 27, 2020

benoitf approved these changes Oct 28, 2020

View reviewed changes

azatsarynnyy approved these changes Oct 28, 2020

View reviewed changes

vinokurig approved these changes Oct 29, 2020

View reviewed changes

Merge with master

d4d9b98

Signed-off-by: Vitaliy Gulyy <[email protected]>

ericwill approved these changes Nov 2, 2020

View reviewed changes

ericwill merged commit 7f117fc into master Nov 2, 2020

ericwill deleted the builtin-plugins branch November 2, 2020 13:00

vitaliy-guliy restored the builtin-plugins branch November 2, 2020 13:14

vitaliy-guliy deleted the builtin-plugins branch November 2, 2020 13:27

azatsarynnyy added a commit that referenced this pull request Nov 3, 2020

Revert "Upate some plugins (#887)"

6351351

This reverts commit 7f117fc.

monaka pushed a commit to PizzaFactory/che-theia that referenced this pull request Nov 4, 2020

Upate some plugins (eclipse-che#887)

383221a

Signed-off-by: Vitaliy Gulyy <[email protected]>

monaka pushed a commit to PizzaFactory/che-theia that referenced this pull request Nov 6, 2020

Upate some plugins (eclipse-che#887)

ea9ff9f

Signed-off-by: Vitaliy Gulyy <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update a couple of built-in plugins #887

Update a couple of built-in plugins #887

vitaliy-guliy commented Oct 21, 2020

che-bot commented Oct 21, 2020

che-bot commented Oct 22, 2020

benoitf commented Oct 22, 2020

vitaliy-guliy commented Oct 22, 2020

vitaliy-guliy commented Oct 22, 2020

che-bot commented Oct 22, 2020

benoitf commented Oct 23, 2020

vitaliy-guliy commented Oct 27, 2020

che-bot commented Oct 27, 2020

vitaliy-guliy commented Oct 28, 2020

che-bot commented Oct 28, 2020

benoitf left a comment

azatsarynnyy left a comment

vinokurig commented Oct 29, 2020 •

edited

Loading

che-bot commented Nov 2, 2020

vitaliy-guliy commented Nov 2, 2020

che-bot commented Nov 2, 2020

vitaliy-guliy commented Nov 2, 2020

che-bot commented Nov 2, 2020

benoitf commented Nov 2, 2020

ericwill commented Nov 2, 2020

benoitf commented Nov 2, 2020

ericwill commented Nov 2, 2020

benoitf commented Nov 2, 2020

azatsarynnyy commented Nov 3, 2020

ericwill commented Nov 3, 2020

azatsarynnyy commented Nov 3, 2020

Update a couple of built-in plugins #887

Update a couple of built-in plugins #887

Conversation

vitaliy-guliy commented Oct 21, 2020

What does this PR do?

What issues does this PR fix or reference?

Happy Path Channel

che-bot commented Oct 21, 2020

che-bot commented Oct 22, 2020

benoitf commented Oct 22, 2020

vitaliy-guliy commented Oct 22, 2020

vitaliy-guliy commented Oct 22, 2020

che-bot commented Oct 22, 2020

benoitf commented Oct 23, 2020

vitaliy-guliy commented Oct 27, 2020

che-bot commented Oct 27, 2020

vitaliy-guliy commented Oct 28, 2020

che-bot commented Oct 28, 2020

benoitf left a comment

Choose a reason for hiding this comment

azatsarynnyy left a comment

Choose a reason for hiding this comment

vinokurig commented Oct 29, 2020 • edited Loading

che-bot commented Nov 2, 2020

vitaliy-guliy commented Nov 2, 2020

che-bot commented Nov 2, 2020

vitaliy-guliy commented Nov 2, 2020

che-bot commented Nov 2, 2020

benoitf commented Nov 2, 2020

ericwill commented Nov 2, 2020

benoitf commented Nov 2, 2020

ericwill commented Nov 2, 2020

benoitf commented Nov 2, 2020

azatsarynnyy commented Nov 3, 2020

ericwill commented Nov 3, 2020

azatsarynnyy commented Nov 3, 2020

vinokurig commented Oct 29, 2020 •

edited

Loading