Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Che operator should be able to install DevWorkspace and DevWorkspace Che operator #19121

Closed
2 tasks done
l0rd opened this issue Feb 22, 2021 · 9 comments
Closed
2 tasks done
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. kind/enhancement A feature request - must adhere to the feature request template. kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed. severity/P1 Has a major impact to usage or development of the system.

Comments

@l0rd
Copy link
Contributor

l0rd commented Feb 22, 2021

Is your enhancement related to a problem? Please describe.

Currently the only way to deploy the DevWorkspac operator is through chectl. When Che is installed from the OperatorHub there is no option to deploy the DevWorkspace controllers and CRDs.

Describe the solution you'd like

Add a new section in CheCluster CRD:

apiVersion: org.eclipse.che/v1
kind: CheCluster
metadata:
  name: eclipse-che
spec:
(...)
  devworkspace:
    # Deploys the DevWorkspace operator in the cluster.
    # Do nothing if a matching version of the operator is already installed.
    # Fail if a non matching version of the operator is already installed. 
    disable: true

Other considerations

The default value of devworkspace.disable is temporarily true but we should switch to false after a few sprints.

When upgrading a previous installation we should explicitly update the CRD to devworkspace.disable=true.

The DevWorkspace operator won't be in the OperatorHub for a few months. In the context of this issue we should assume that it's not published in the OperatorHub.

Subtasks

@l0rd l0rd added the kind/enhancement A feature request - must adhere to the feature request template. label Feb 22, 2021
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Feb 22, 2021
@l0rd l0rd added engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Feb 22, 2021
@l0rd l0rd added this to the DevWorkspace Integration - STEP1 milestone Feb 22, 2021
@tolusha tolusha mentioned this issue Feb 23, 2021
57 tasks
@sleshchenko
Copy link
Member

As we discussed with @l0rd today:

  1. Che DevWorkspace Operator should be deployed as well, until it's not fully merged into Che Operator chectl should deploy devworkspace-che-operator when the engine is devworkspace #19001
  2. Ideally chectl just reuse Che Operator functionality but don't duplicate logic and apply resources by itself, but that's not requirement.
    For milestone 1, devworkspace should be supported only on OpenShift + OpenShift OAuth.

@l0rd please review.

@l0rd
Copy link
Contributor Author

l0rd commented Feb 23, 2021

@l0rd please review.

👍

@tolusha tolusha added the severity/P1 Has a major impact to usage or development of the system. label Feb 24, 2021
@tolusha tolusha mentioned this issue Feb 25, 2021
70 tasks
@sleshchenko
Copy link
Member

sleshchenko commented Mar 2, 2021

DevWorkspace support also depends on SingleHost (powered by gateway).
So, we either should default to SingleHost when DevWorkspace support is enabled or fail if it's not enabled

@l0rd l0rd changed the title Che operator should be able to install DevWorkspace operator Che operator should be able to install DevWorkspace and DevWorkspace Che operator Mar 3, 2021
@l0rd
Copy link
Contributor Author

l0rd commented Mar 3, 2021

I have added #19142 as a subtask of this epic.

@l0rd
Copy link
Contributor Author

l0rd commented Mar 5, 2021

@tolusha I am keeping this issue open as #19142 hasn't been resolved yet.

@l0rd l0rd reopened this Mar 5, 2021
@tolusha
Copy link
Contributor

tolusha commented Mar 5, 2021

yes. make sense
some notes: I've decided to change the fields.
Have disable sounds odd to me since CR is used to enable some features rather than disable.

spec:
  devWorkspace:
    enable: true

@l0rd
Copy link
Contributor Author

l0rd commented Mar 5, 2021

@tolusha I don't know if that's already the case but it would be helpful to add a mention in the docs about it (see the third checkbox in this epic)

@tolusha
Copy link
Contributor

tolusha commented Mar 9, 2021

Here is
eclipse-che/che-docs#1895

@l0rd
Copy link
Contributor Author

l0rd commented Mar 15, 2021

I am closing this epic as the linked issues has been closed. I haven't been able to test it though. I have opened a separate issue for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. kind/enhancement A feature request - must adhere to the feature request template. kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

4 participants