Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidecar filesystem/content reader will not work in front-end plugins #20331

Closed
tsmaeder opened this issue Aug 18, 2021 · 2 comments
Closed

Sidecar filesystem/content reader will not work in front-end plugins #20331

tsmaeder opened this issue Aug 18, 2021 · 2 comments
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/bug Outline of a bug - must adhere to the bug report template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P2 Has a minor but important impact to the usage or development of the system.

Comments

@tsmaeder
Copy link
Contributor

tsmaeder commented Aug 18, 2021

Describe the bug

We have two classes in che-sidecar-content-reader.ts and che-sidecar-file-system.ts which read files form the sidecar container. They are implemented with the che plugin api. However, these two classes don't make sense when the che api is run as a front-end API.

We should decide whether running the che api as a front end plugin API makes sense at all. If we decide it does, we need to find a way to cleanly exclude the part of the API (in particular, when building the webpack version of the API).

@tsmaeder tsmaeder added the kind/bug Outline of a bug - must adhere to the bug report template. label Aug 18, 2021
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Aug 18, 2021
@tolusha tolusha added severity/P2 Has a minor but important impact to the usage or development of the system. area/editor/theia Issues related to the che-theia IDE of Che and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Aug 18, 2021
@tsmaeder
Copy link
Contributor Author

T.b.h, I think the setup of those services in the plugin host process should be separated from the setup of the API (they provide nothing into the che API namespace): the services should be hooked up to the rpc instance somewhere in the setup up of the remote plugins host processs.

@che-bot
Copy link
Contributor

che-bot commented Feb 15, 2022

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 15, 2022
@che-bot che-bot closed this as completed Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/bug Outline of a bug - must adhere to the bug report template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Development

No branches or pull requests

3 participants