Align che-theia with upstream changes

[vitaliy-guliy]

Describe the bug

It seems the commit to the upstream broke che-theia.

che-theia image can be built successfully (no any issues, as tests are turned off), but the container fails with the following output

TypeError: Class constructor MessagingContribution cannot be invoked without 'new'
    at new CheMessagingContribution (/home/theia/node_modules/@eclipse-che/theia-messaging/lib/node/messaging/che-messaging-contribution.js:78:47)
    at _createInstance (/home/theia/node_modules/inversify/lib/resolution/instantiation.js:27:12)
    at Object.resolveInstance (/home/theia/node_modules/inversify/lib/resolution/instantiation.js:47:18)
    at /home/theia/node_modules/inversify/lib/resolution/resolver.js:75:42
    at Object.resolve (/home/theia/node_modules/inversify/lib/resolution/resolver.js:99:12)
    at /home/theia/node_modules/inversify/lib/container/container.js:335:37
    at Container._get (/home/theia/node_modules/inversify/lib/container/container.js:326:44)
    at Container.get (/home/theia/node_modules/inversify/lib/container/container.js:243:21)
    at Binding.dynamicValue (/home/theia/node_modules/inversify/lib/syntax/binding_to_syntax.js:76:75)
    at /home/theia/node_modules/inversify/lib/resolution/resolver.js:66:118
Theia app listening on http://127.0.0.1:3100.

Che version

next (development version)

Steps to reproduce

a) Since build of eclipse/che-theia:next is broken (the image must be published on each change), it needs to build the image by hands.

1. clone che-theia, build the image

./build.sh --build-args:GITHUB_TOKEN=${GITHUB_TOKEN} --skip-tests --dockerfile:Dockerfile.alpine

2. then use this image when creating a workspace

b) Create a workspace using the devfile

apiVersion: 1.0.0
metadata:
  name: che-theia-next
projects:
  - name: web-java-spring-petclinic
    source:
      location: 'https://github.com/che-samples/java-spring-petclinic'
      type: git
components:
  - type: cheEditor
    alias: che-theia
    reference: https://gist.githubusercontent.com/vitaliy-guliy/2bb6318a84a2911e334cba6d7dfbf423/raw/b52df74920ace02d0c11d35c01bc621eadb5d3bd/editor.meta.yaml

Expected behavior

Working editor.

Runtime

OpenShift, minikube

Screenshots

Installation method

chectl/next

Environment

Linux, Dev Sandbox (workspaces.openshift.com)

Eclipse Che Logs

No response

Additional context

To build che-theia use eclipse-che/che-theia/main and eclipse-theia/theia/master

[RomanNikitenko]

I detected one more breaking change:

activation of extensions fails (Language Support for Java(TM) by Red Hat and Debugger for Java):

[azatsarynnyy]

Probably, it's related #20360

[RomanNikitenko]

Probably, it's related #20360

I guess it's related to https://github.com/eclipse-theia/theia/pull/9660
I pinned che-theia before those changes within my PR eclipse-che/che-theia#1205 and it works well.

[azatsarynnyy]

Cool! Now, we can stabilize Che-Theia build and continue the investigation. Thanks @RomanNikitenko!

[azatsarynnyy]

I'm lowering the severity from blocker to P1, as we've pinned Che-Theia to a specific upstream Theia commit SHA.
Currently, Che-Theia build is stabilized and we continue working on adapting to the upstream breaking changes.

[tsmaeder]

Looking at the compiled javascript of the stack trace given in the description makes me think it is a problem with compiling to ES2017.

[azatsarynnyy]

Looking at the compiled javascript of the stack trace given in the description makes me think it is a problem with compiling to ES2017.

@tsmaeder your guesses are correct. See the more details in the draft PR eclipse-che/che-theia#1213 (comment)

[azatsarynnyy]

It should be already fixed by eclipse-che/che-theia#1213