Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When admin switches the engine to DevWorskpace all che-server based workspaces should be stopped #20631

Closed
ibuziuk opened this issue Oct 12, 2021 · 5 comments
Assignees
Labels
area/che-server area/devworkspace-operator kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system. sprint/current status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community.
Milestone

Comments

@ibuziuk
Copy link
Member

ibuziuk commented Oct 12, 2021

Describe the bug

  • install 'eclipse-che' using the stable channel
  • create CR with a single-host and OpenShift Auth enabled
  • create an account (using 'developer' OpenShift account on the crc for example) with a couple of workspaces and start one of them
  • wait until workspace is running, run build / run command
  • update the CR from the eclipse-che namespace and enable devWorkspace
  devWorkspace:
    enable: true
  • go back to the running workspace - UD does not show it anymore, however workspace pod is still running
  • ERROR: previously running workspace pod is still running, even though UD does not show it

Che version

7.37@latest

Steps to reproduce

  • install 'eclipse-che' using the stable channel
  • create CR with a single-host and OpenShift Auth enabled
  • create an account (using 'developer' OpenShift account on the crc for example) with a couple of workspaces and start one of them
  • wait until workspace is running, run build / run command
  • update the CR from the eclipse-che namespace and enable devWorkspace
  devWorkspace:
    enable: true
  • go back to the running workspace - UD does not show it anymore, however workspace pod is still running
  • ERROR: previously running workspace pod is still running, even though UD does not show it

Expected behavior

When admin switches the engine to DevWorskpace all che-server based workspaces should be stopped

Runtime

OpenShift

Screenshots

When admin switches the engine to DevWorskpace all che-server based workspaces should be stopped

Installation method

OperatorHub

Environment

Linux

Eclipse Che Logs

No response

Additional context

No response

@ibuziuk ibuziuk added kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system. area/devworkspace-operator labels Oct 12, 2021
@l0rd
Copy link
Contributor

l0rd commented Oct 13, 2021

But the way to switch to the DW should be to use the all-namespace channel rather than updating the CheCluster CR (although this issue will still be there, but switching to all-namespace channel is important to avoid other kind of problems).

@ibuziuk
Copy link
Member Author

ibuziuk commented Oct 18, 2021

This issue happens after the switch from stable to all-namespace - more details in #20614 (comment)

@ibuziuk ibuziuk added this to the 7.39 milestone Oct 19, 2021
@ibuziuk ibuziuk self-assigned this Oct 21, 2021
@ibuziuk ibuziuk added sprint/current status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. and removed sprint/next labels Nov 9, 2021
@ibuziuk ibuziuk modified the milestones: 7.39, 7.40 Nov 10, 2021
@ibuziuk
Copy link
Member Author

ibuziuk commented Nov 10, 2021

PR has been merged eclipse-che/che-server#177
Closing

@ibuziuk ibuziuk closed this as completed Nov 10, 2021
@nickboldt
Copy link
Contributor

So with this change, once a CRW instance is updated from 'latest' (no DW) to 'all-namespaces' (DW enabled)...

  • existing workspaces are stopped

How does a user restart the workspace? Will it be automatically converted to v2.1 for them?

Or, will they have to manually fix things, in one of two ways:

a) manually update the devfile in the dashboard editor to upgrade it to v2.1 (and then commit these changes back to their source repo so changes are persisted)

b) open a NEW workspace from the existing devfile via the factory URL, and have it converted for the user automatically... then user needs to remember to commit the updated devfile back to the source repo so the converted version 2.1 flavour instead of the now-obsolete 1.0 flavour is kept and can be reused.

Are those the correct user stories?

@dmytro-ndp
Copy link
Contributor

@nickboldt : there is an issue about further actions: #20845

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/che-server area/devworkspace-operator kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system. sprint/current status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community.
Projects
None yet
Development

No branches or pull requests

4 participants