Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub authentication manual flow #20995

Closed
vinokurig opened this issue Jan 10, 2022 · 5 comments · Fixed by eclipse-che/che-theia#1293
Closed

Add GitHub authentication manual flow #20995

vinokurig opened this issue Jan 10, 2022 · 5 comments · Fixed by eclipse-che/che-theia#1293
Assignees
Labels
area/plugins engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system. sprint/current

Comments

@vinokurig
Copy link
Contributor

Is your task related to a problem? Please describe

Since GitHub oauth flow is not implemented for the DevWorkspace engine, we need to have an ability to manually add a GitHub token.

Describe the solution you'd like

  • Show an input box which asks for a GitHub token.
  • Store the token in the workspace-credentials-secret secret.
  • Get the token from the secret when needed.

Describe alternatives you've considered

No response

Additional context

No response

@vinokurig vinokurig added the kind/task Internal things, technical debt, and to-do tasks to be performed. label Jan 10, 2022
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jan 10, 2022
@svor svor added area/plugins engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. severity/P1 Has a major impact to usage or development of the system. team/plugins and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Jan 10, 2022
@svor
Copy link
Contributor

svor commented Jan 10, 2022

@benoitf @l0rd FYI

@benoitf
Copy link
Contributor

benoitf commented Jan 10, 2022

I was wondering if when using oAuth, dashboard could not write the github token in the user namespace

so editor will just read it (no need to prompt the user)

@vinokurig
Copy link
Contributor Author

Dashboard uses che-server oauth API which is going to be deprecated right?

@benoitf
Copy link
Contributor

benoitf commented Jan 10, 2022

if I try to use a private repository, I've a personal token secret in my user namespace

kind: Secret
apiVersion: v1
metadata:
  name: personal-access-token-4v47q
  namespace: opentlc-mgr-che
  resourceVersion: '79901'
  labels:
    app.kubernetes.io/component: scm-personal-access-token
    app.kubernetes.io/part-of: che.eclipse.org
  annotations:
    che.eclipse.org/che-userid: .....
    che.eclipse.org/scm-personal-access-token-id: id-o1gt2
    che.eclipse.org/scm-personal-access-token-name: oauth2-pegbi
    che.eclipse.org/scm-url: 'https://github.com'
    che.eclipse.org/scm-userid: 'xxx'
    che.eclipse.org/scm-username: benoitf

@benoitf
Copy link
Contributor

benoitf commented Jan 10, 2022

Dashboard uses che-server oauth API which is going to be deprecated right?

The idea is to decouple things that are today being tied.

Import a repository from github: always use oAuth flow: #20583
Need a token: --> read the secret

so editor don't need to get any oAuth configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugins engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system. sprint/current
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants