Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chectl --version flag doesn't work any more #21001

Closed
mmorhun opened this issue Jan 11, 2022 · 6 comments
Closed

chectl --version flag doesn't work any more #21001

mmorhun opened this issue Jan 11, 2022 · 6 comments
Labels
area/chectl Issues related to chectl, the CLI of Che kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system. sprint/current
Milestone

Comments

@mmorhun
Copy link
Contributor

mmorhun commented Jan 11, 2022

Describe the bug

Even if the version flag given, chectl tries to deploy Che in the new manner (for devworkspaces)

Che version

next (development version)

Steps to reproduce

Run deploy command with version flag, for example:

chectl server:deploy --version=7.39.0 -p minikube

Expected behavior

--version flags works
or
we release Che 8 and do not support Che 7.x versions any more

Runtime

minikube, CodeReady Container

Screenshots

N/A

Installation method

chectl/next

Environment

Linux

Eclipse Che Logs

N/A

Additional context

No response

@mmorhun mmorhun added kind/bug Outline of a bug - must adhere to the bug report template. area/chectl Issues related to chectl, the CLI of Che labels Jan 11, 2022
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jan 11, 2022
@azatsarynnyy azatsarynnyy added severity/P1 Has a major impact to usage or development of the system. team/deploy and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Jan 11, 2022
@tolusha
Copy link
Contributor

tolusha commented Jan 12, 2022

We don't have statisticks regarding flag --version on Woopra

@tolusha
Copy link
Contributor

tolusha commented Feb 4, 2022

It is possible to easily update chectl to a specific version to deploy a corresponding version of Eclipse Che.
(For linux)

  1. Download chectl
chectl_version=7.39.0
mkdir ~/.local/share/chectl/client/${chectl_version}
curl -L  https://github.com/che-incubator/chectl/releases/download/7.40.0/chectl-linux-x64.tar.gz  | tar -xz -C   ~/.local/share/chectl/client/${chectl_version} --strip-components=1
  1. Update to chectl from a local repository
    chectl update --from-local and select a desired version

Having this I believe when can drop --version flag to simplify codebase

@tolusha
Copy link
Contributor

tolusha commented Feb 4, 2022

/cc @l0rd

@l0rd
Copy link
Contributor

l0rd commented Feb 4, 2022

@tolusha does the --version work for 7.42 and above (devworkspace based versions)? Or even --version 7.42 doesn't work?

@tolusha
Copy link
Contributor

tolusha commented Feb 4, 2022

To support --version 7.42.0, I need to keep some code related to backup/restore, which has been removed here che-incubator/chectl#1996
So, answer is No now.

If we decide to support it, then I will need to keep codebase related to different versions of CheCluster (#20758), which I would like to avoid

@l0rd
Copy link
Contributor

l0rd commented Feb 4, 2022

Ok I agree with you.

Instead of removing --version, can we keep it but return an error and print the message with the "workaround" or pointing to a doc with the "workaround" or to your comment above if someone specifies it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/chectl Issues related to chectl, the CLI of Che kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system. sprint/current
Projects
None yet
Development

No branches or pull requests

5 participants