Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devfile attribute is not propagated #21428

Closed
Tracked by #21438
l0rd opened this issue May 27, 2022 · 2 comments · Fixed by eclipse-che/che-dashboard#564
Closed
Tracked by #21438

Devfile attribute is not propagated #21428

l0rd opened this issue May 27, 2022 · 2 comments · Fixed by eclipse-che/che-dashboard#564
Labels
area/dashboard kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system. sprint/next

Comments

@l0rd
Copy link
Contributor

l0rd commented May 27, 2022

Describe the bug

The attribute controller.devfile.io/scc: container-build (used in this devfile for example) is not added in the corresponding DevWorkspace CR.

Note that this attribute is required to be able to run rootless build using buildah.

Che version

next (development version)

Steps to reproduce

  • Use this devfile to start a workspaces
  • The corresponding DevWorkspace doesn't have the scc attribute:
$ k get dw tilt-n-quarkus -o json | jq '.spec.template.attributes'
{
  "controller.devfile.io/storage-type": "ephemeral"
}

Expected behavior

I would expect that every attribute would be propagated, even attributes that are not known by Che.

Runtime

OpenShift

Screenshots

No response

Installation method

OperatorHub

Environment

Amazon

@l0rd l0rd added the kind/bug Outline of a bug - must adhere to the bug report template. label May 27, 2022
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label May 27, 2022
@l0rd
Copy link
Contributor Author

l0rd commented May 27, 2022

Related to #21164 cc @olexii4

@l0rd l0rd added area/dashboard severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels May 27, 2022
@l0rd
Copy link
Contributor Author

l0rd commented May 27, 2022

As a "workaround"

# wait the workspace to start and then...
k patch dw <dwname> \
    --type='merge' \
    -p '{"spec":{"template":{"attributes":{"controller.devfile.io/scc": "container-build"}}}}'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dashboard kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system. sprint/next
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants