Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UD] Improve handling changes in devworkspaces #21607

Closed
akurinnoy opened this issue Aug 3, 2022 · 1 comment
Closed

[UD] Improve handling changes in devworkspaces #21607

akurinnoy opened this issue Aug 3, 2022 · 1 comment
Assignees
@akurinnoy
Labels
area/dashboard kind/task Internal things, technical debt, and to-do tasks to be performed. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P2 Has a minor but important impact to the usage or development of the system.

Comments

@akurinnoy
Copy link
Contributor

Is your task related to a problem? Please describe

Module devWorkspaceClient propagates only the subset of the update it receives, and that doesn't allow the Dashboard to correctly handle changes in devworkspaces, i.e., fetching changes of mainUrl, and the devworkspace status messages.

The current implementation is prone to bugs like #21308

Describe the solution you'd like

A better solution will be to propagate the whole devworkspace object, and update the Redux store with the correct data.

Describe alternatives you've considered

No response

Additional context

No response
@akurinnoy akurinnoy added kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P2 Has a minor but important impact to the usage or development of the system. area/dashboard team/controller labels Aug 3, 2022
@akurinnoy akurinnoy self-assigned this Aug 3, 2022
@akurinnoy akurinnoy changed the title [UD] Improve handling of status changes in devworkspaces [UD] Improve handling changes in devworkspaces Aug 3, 2022
@che-bot
Copy link
Contributor

che-bot commented Jun 7, 2023

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 7, 2023
@che-bot che-bot closed this as completed Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akurinnoy akurinnoy

Labels
area/dashboard kind/task Internal things, technical debt, and to-do tasks to be performed. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nickboldt @akurinnoy @che-bot