-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow che administrators to enable container build capabilities for developers workspaces #21752
Comments
@l0rd |
spec:
devEnvironments:
disableContainerBuildCapabilities: false # <== default is false |
from the semantics perspective it would be better to drop the negative connotation (disable field set to false) and use
|
I am ok with both but in the past we have been trying to stick with the following convention: omitting a boolean field corresponds to setting it to |
I have added the full list of tasks to automate the enabling of the workspaces container build capabilities in #21764. spec:
devEnvironments:
disableContainerBuildCapabilities: false # initially the default is `true`
containerBuildConfiguration:
openShiftSecurityContextConstraint: 'container-build'
containerOverrides: {"securityContext":{"capabilities":{"add": ["SETGID", "SETUID"]}}}
podOverrides: {"spec": {"securityContext": {"allowPrivilegeEscalation": false}}} |
Sync'd with Red Hat JIRA https://issues.redhat.com/browse/CRW-3637 |
Is your enhancement related to a problem? Please describe
Today it's only possible to add the capability through an attribute in a devfile and this is not portable.
Describe the solution you'd like
Add to the CheCluster a field to enable the container build capabilties and update the dashboard to consume it at workspace startup:
Release Notes Text
An administrator can enable container builds using
devEnvironments.disableContainerBuildCapabilities: true
in CheCluster configuration. This allow usingpodman build
on any workspace (adding the attributecontroller.devfile.io/scc: container-build
in a Devfile is not required anymore) .The text was updated successfully, but these errors were encountered: