Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing Git zero-config flow as PR checks #21753

Closed
10 tasks done
svor opened this issue Oct 10, 2022 · 7 comments
Closed
10 tasks done

Testing Git zero-config flow as PR checks #21753

svor opened this issue Oct 10, 2022 · 7 comments
Assignees
Labels
area/git/oauth-services OAuth support to authenticate developers with their GitHub, GitLab, Bitbucket etc...accounts kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system. team/A This team is responsible for the Che Operator and all its operands as well as chectl and Hosted Che

Comments

@svor
Copy link
Contributor

svor commented Oct 10, 2022

Is your task related to a problem? Please describe

As a result of #20583, we've added a support for many git services (GitHub, BitBucket, GitLab)
It would be good to test the existing git flow as much as possible.

Describe the solution you'd like

Unit Test:

  • Add unit tests into che-server to cover git providers functionality

Add instructions how to prepare Git servers to work with Che, it could be a part of https://github.com/eclipse-che/che-server repository or a new repo in https://github.com/che-incubator:

Add GitHub action to get che-server image with a current PR number:

  • Build and pull che-server image to quay.io/repository/eclipse/che-server with a curent PR number

Configure OpenShift CI infrastructure to run git functional tests as PR check:

  • tests without PAT/OAuth setup flow:

  • Bitbucket.org

  • GitHub.com

  • GitLab.com

  • tests with PAT setup flow

  • GitHub.com

  • GitLab.com

@svor svor added kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P2 Has a minor but important impact to the usage or development of the system. area/git labels Oct 10, 2022
@svor svor mentioned this issue Oct 11, 2022
67 tasks
This was referenced Oct 28, 2022
@dmytro-ndp
Copy link
Contributor

dmytro-ndp commented Nov 7, 2022

@svor
Copy link
Contributor Author

svor commented Nov 8, 2022

Thanks @dmytro-ndp for the links!

@l0rd l0rd changed the title Testing Git zero flow Testing Git zero-config flow Nov 17, 2022
@svor
Copy link
Contributor Author

svor commented Nov 22, 2022

@l0rd The instructions how to prepare Git servers to work with Che/DS were added into https://github.com/che-incubator/git-srv.
Should we add the link to this repo somewhere, maybe in docks?

@l0rd
Copy link
Contributor

l0rd commented Nov 22, 2022

This is useful for contributors so my proposal is to add the link in a section of the contributing.md.

@vinokurig
Copy link
Contributor

While investigating the GitHub action test flow I've faced a problem:
The initial idea is to send a Che API request and check the result. The Che Api is available only through the oAuth step. In case of Openshift it is the OpenShift oauth-proxy and in case of minikube it is Dax. So when I request Che API directly by curl it returns an authorisation html. So I don't see a way how to make an API request to Che to test the Che oAuth flow without using UI.

@l0rd l0rd added area/git/oauth-services OAuth support to authenticate developers with their GitHub, GitLab, Bitbucket etc...accounts and removed area/git labels Jan 23, 2023
@ibuziuk ibuziuk mentioned this issue Feb 14, 2023
56 tasks
@l0rd
Copy link
Contributor

l0rd commented Feb 14, 2023

@ibuziuk ibuziuk added team/A This team is responsible for the Che Operator and all its operands as well as chectl and Hosted Che severity/P1 Has a major impact to usage or development of the system. labels Mar 9, 2023
@artaleks9 artaleks9 assigned artaleks9 and unassigned vinokurig Mar 9, 2023
@ibuziuk ibuziuk mentioned this issue Mar 22, 2023
50 tasks
@artaleks9 artaleks9 added the status/in-progress This issue has been taken by an engineer and is under active development. label Mar 22, 2023
@ibuziuk ibuziuk removed the severity/P2 Has a minor but important impact to the usage or development of the system. label Mar 22, 2023
@ibuziuk ibuziuk changed the title Testing Git zero-config flow Testing Git zero-config flow as PR checks Mar 30, 2023
@ibuziuk ibuziuk moved this to 📋 Backlog in Eclipse Che Team A Backlog Apr 5, 2023
@ibuziuk ibuziuk moved this from 📋 Backlog to 🚧 In Progress in Eclipse Che Team A Backlog Apr 5, 2023
@ibuziuk ibuziuk moved this from 🚧 In Progress to Ready for Review in Eclipse Che Team A Backlog May 17, 2023
@ibuziuk ibuziuk moved this from Ready for Review to 🚧 In Progress in Eclipse Che Team A Backlog May 17, 2023
@artaleks9 artaleks9 moved this from 🚧 In Progress to Ready for Review in Eclipse Che Team A Backlog May 22, 2023
@artaleks9
Copy link
Contributor

  • I think, this issue can be closed considering to merged PR's, see above.
  • I'll create another issue where try to implement setup git provider/s OAuth to expand exist tests for Git-zero flow.

@ibuziuk ibuziuk moved this from Ready for Review to ✅ Done in Eclipse Che Team A Backlog May 31, 2023
@artaleks9 artaleks9 removed the status/in-progress This issue has been taken by an engineer and is under active development. label Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/git/oauth-services OAuth support to authenticate developers with their GitHub, GitLab, Bitbucket etc...accounts kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system. team/A This team is responsible for the Che Operator and all its operands as well as chectl and Hosted Che
Projects
None yet
Development

No branches or pull requests

6 participants