Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Events and commands defined in che-editors.yaml file are ignored #22071

Closed
RomanNikitenko opened this issue Mar 20, 2023 · 1 comment
Closed

Events and commands defined in che-editors.yaml file are ignored #22071

RomanNikitenko opened this issue Mar 20, 2023 · 1 comment
Assignees
@RomanNikitenko
Labels
area/plugin-registry kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.

Comments

@RomanNikitenko
Copy link
Member

RomanNikitenko commented Mar 20, 2023 •
edited
Loading

Describe the bug

There is a bug in plugin-registry: events and commands defined for an editor in meta.yaml file are ignored.

Che version

7.61@latest

Steps to reproduce

  1. Define an event or command for an editor in the che-editors.yaml file.
  2. Apply the changes for the plugin-registry at starting a workspace
  3. Check if your event or command is applied.

Another way:

  1. Define an event or command for an editor in the che-editors.yaml file.
  2. See feat: Use post-start event to start VS Code che-plugin-registry#1566 (review) for the next steps.

Expected behavior

Commands and events defined in the che-editors.yaml file are not ignored.

Additional context

Please see eclipse-che/che-plugin-registry#1566 (review)
@RomanNikitenko RomanNikitenko added kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system. area/plugin-registry labels Mar 20, 2023
@RomanNikitenko RomanNikitenko changed the title Events and commands defined in meta.yaml file are ignored Events and commands defined in che-editors.yaml file are ignored Mar 20, 2023
@RomanNikitenko RomanNikitenko self-assigned this Mar 20, 2023
This was referenced Mar 20, 2023
Merged
Closed
Merged
@RomanNikitenko RomanNikitenko added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. and removed status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels Mar 21, 2023
@RomanNikitenko
Copy link
Member Author

Fixed by eclipse-che/che-plugin-registry#1613

@RomanNikitenko RomanNikitenko mentioned this issue Mar 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RomanNikitenko RomanNikitenko

Labels
area/plugin-registry kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RomanNikitenko