Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove storageClass related fields from VolumePermissionEnricher #1989

Closed
1 task
rohanKanojia opened this issue Jan 4, 2023 · 6 comments · Fixed by #3194
Closed
1 task

Remove storageClass related fields from VolumePermissionEnricher #1989

rohanKanojia opened this issue Jan 4, 2023 · 6 comments · Fixed by #3194
Assignees
Milestone

Comments

@rohanKanojia
Copy link
Member

Component

JKube Kit

Task description

Description

Related to #1179 #1928

🚧 Requires #1928 to get merged and released so that we can remove deprecated fields in this release 🚧

VolumePermissionEnricher seems to be doing more than just changing permission of mounted volume. It also seems to be setting storageClass in PVC.

We moved storageClass related logic in #1928 into PersistentVolumeClaimStorageClassEnricher. However, there are these configuration fields still present in VolumePermissionEnricher:

https://github.com/eclipse/jkube/blob/751a8aacd83de57cf05256a0c7e493926a752652/jkube-kit/enricher/generic/src/main/java/org/eclipse/jkube/enricher/generic/VolumePermissionEnricher.java#L63-L64

They've been marked as @Deprecated for now but we need to remove this in future.

This is just a reminder task to remove these configuration fields and related methods from VolumePermissionEnricher in future.

Expected Behavior

VolumePermissionEnricher shouldn't have any configuration fields related to storageClass

Acceptance Criteria

  • defaultStorageClass and useStorageClassAnnotation have been removed from VolumePermissionEnricher.Config
@omjikush09
Copy link
Contributor

Hi, can I work on this?

@rohanKanojia
Copy link
Member Author

Sorry, I created this task for future reference. /it's not applicable at the moment

Requires #1928 to get merged and released so that we can remove deprecated fields in this release

Shall I create some other issue for you to pick up?

@omjikush09
Copy link
Contributor

Hi,@rohanKanojia It would be great if you could create some new issues; I would love to contribute.
Thanks for it.

@omjikush09
Copy link
Contributor

Hi, @rohanKanojia and @sunix can I work on this now?

@rohanKanojia
Copy link
Member Author

@omjikush09 : Sorry #1928 still isn't merged yet. Shall I create some other issue for you to pick up?

@omjikush09
Copy link
Contributor

Yup that would be great. 😄

@manusa manusa moved this to Planned in Eclipse JKube May 15, 2024
@rohanKanojia rohanKanojia self-assigned this Jun 24, 2024
@rohanKanojia rohanKanojia moved this from Planned to In Progress in Eclipse JKube Jun 24, 2024
@manusa manusa added this to the 1.17.0 milestone Jun 25, 2024 — with automated-tasks
@manusa manusa moved this from In Progress to Review in Eclipse JKube Jun 25, 2024
@github-project-automation github-project-automation bot moved this from Review to Done in Eclipse JKube Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants