-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove storageClass related fields from VolumePermissionEnricher #1989
Comments
Hi, can I work on this? |
Sorry, I created this task for future reference. /it's not applicable at the moment
Shall I create some other issue for you to pick up? |
Hi,@rohanKanojia It would be great if you could create some new issues; I would love to contribute. |
Hi, @rohanKanojia and @sunix can I work on this now? |
@omjikush09 : Sorry #1928 still isn't merged yet. Shall I create some other issue for you to pick up? |
Yup that would be great. 😄 |
Component
JKube Kit
Task description
Description
Related to #1179 #1928
🚧 Requires #1928 to get merged and released so that we can remove deprecated fields in this release 🚧
VolumePermissionEnricher seems to be doing more than just changing permission of mounted volume. It also seems to be setting storageClass in PVC.
We moved storageClass related logic in #1928 into PersistentVolumeClaimStorageClassEnricher. However, there are these configuration fields still present in VolumePermissionEnricher:
https://github.com/eclipse/jkube/blob/751a8aacd83de57cf05256a0c7e493926a752652/jkube-kit/enricher/generic/src/main/java/org/eclipse/jkube/enricher/generic/VolumePermissionEnricher.java#L63-L64
They've been marked as
@Deprecated
for now but we need to remove this in future.This is just a reminder task to remove these configuration fields and related methods from VolumePermissionEnricher in future.
Expected Behavior
VolumePermissionEnricher shouldn't have any configuration fields related to storageClass
Acceptance Criteria
defaultStorageClass
anduseStorageClassAnnotation
have been removed from VolumePermissionEnricher.ConfigThe text was updated successfully, but these errors were encountered: