You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While working on #1980 , we realized we might want to change this behavior.
I faced this issue yesterday while adapting the Apache Tomee quickstart (#1972). We might want to improve the IngressEnricher so that it can merge stuff for provided incompleteIngress fragments.
IngressEnricher should check if provided Ingress fragment is valid and merge opinionated defaults if it's not complete. We should properly discuss these scenario and define what we expect.
Acceptance Criteria
Needs to be discussed.
The text was updated successfully, but these errors were encountered:
Component
JKube Kit
Task description
Description
Currently, IngressEnricher simply returns when it discovers an Ingress resource already present.
https://github.com/eclipse/jkube/blob/bb9794e6a5ee4cf0a66b7e0b5e38feb35df9a711/jkube-kit/enricher/generic/src/main/java/org/eclipse/jkube/enricher/generic/IngressEnricher.java#L77-L80
While working on #1980 , we realized we might want to change this behavior.
Originally posted by @manusa in #1980
Expected Behavior
IngressEnricher should check if provided Ingress fragment is valid and merge opinionated defaults if it's not complete. We should properly discuss these scenario and define what we expect.
Acceptance Criteria
The text was updated successfully, but these errors were encountered: