Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define Behavior of IngressEnricher in presence of an Ingress fragment #1990

Open
1 task
rohanKanojia opened this issue Jan 5, 2023 · 0 comments
Open
1 task

Comments

@rohanKanojia
Copy link
Member

Component

JKube Kit

Task description

Description

Currently, IngressEnricher simply returns when it discovers an Ingress resource already present.

https://github.com/eclipse/jkube/blob/bb9794e6a5ee4cf0a66b7e0b5e38feb35df9a711/jkube-kit/enricher/generic/src/main/java/org/eclipse/jkube/enricher/generic/IngressEnricher.java#L77-L80

While working on #1980 , we realized we might want to change this behavior.

I faced this issue yesterday while adapting the Apache Tomee quickstart (#1972). We might want to improve the IngressEnricher so that it can merge stuff for provided incomplete Ingress fragments.

Originally posted by @manusa in #1980

Expected Behavior

IngressEnricher should check if provided Ingress fragment is valid and merge opinionated defaults if it's not complete. We should properly discuss these scenario and define what we expect.

Acceptance Criteria

  • Needs to be discussed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant