Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jkube.enricher.jkube-service.name is not working when providing fragments #2350

Closed
manusa opened this issue Aug 25, 2023 · 1 comment · Fixed by #2355 or #2362
Closed

jkube.enricher.jkube-service.name is not working when providing fragments #2350

manusa opened this issue Aug 25, 2023 · 1 comment · Fixed by #2355 or #2362
Assignees
Labels
bug Something isn't working
Milestone

Comments

@manusa
Copy link
Member

manusa commented Aug 25, 2023

Description

When trying to override the service name using the Enricher configuration, if a fragment is provided, then the name is ignored.

Other enrichers affected

  • DefaultControllerEnricher
    Not really affected since this enricher is only applicable when no Controller resources exist (i.e. it's skipped if a fragment exists)
  • ControllerViaPluginConfigurationEnricher
  • RouteEnricher

Discussion context

I tried to override the
jkube.enricher.jkube-name.name or the jkube.enricher.jkube-service.name properties separately . The first one really changed the name of the deployment name and the service name in the yaml file , and the second did not change the name of service name in the yaml file.

Originally posted by @maodia in #2342 (comment)

@manusa manusa added the bug Something isn't working label Aug 25, 2023
@manusa manusa added this to the 1.14.0 milestone Aug 25, 2023
@manusa manusa moved this to Planned in Eclipse JKube Aug 25, 2023
@manusa manusa self-assigned this Aug 25, 2023
@manusa manusa moved this from Planned to In Progress in Eclipse JKube Aug 25, 2023
@manusa manusa moved this from In Progress to Review in Eclipse JKube Aug 28, 2023
@manusa manusa moved this from Review to In Progress in Eclipse JKube Aug 29, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Eclipse JKube Aug 29, 2023
@manusa manusa reopened this Aug 29, 2023
@manusa
Copy link
Member Author

manusa commented Aug 30, 2023

Hi @maodia,

The latest snapshot release contains the fix for your issue, could you please try it out and confirm that everything is working as expected?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment