Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helm: values.yaml sorted alphabetically #2389

Closed
manusa opened this issue Sep 25, 2023 · 0 comments · Fixed by #2509
Closed

Helm: values.yaml sorted alphabetically #2389

manusa opened this issue Sep 25, 2023 · 0 comments · Fixed by #2509
Assignees
@rohanKanojia
Labels
component/helm ⎈
Milestone
1.16.0

Comments

@manusa
Copy link
Member

manusa commented Sep 25, 2023

Description

To allow reproducible builds and prevent diffs when committing the generated values.yaml file, the values should be sorted in a predictable and reproducible way (alphabetically should work).

Adding a final sort step to createValuesYaml or
collectParameters should suffice.
@rohanKanojia rohanKanojia moved this to Planned in Eclipse JKube Nov 8, 2023
@rohanKanojia rohanKanojia self-assigned this Dec 29, 2023
@rohanKanojia rohanKanojia moved this from Planned to In Progress in Eclipse JKube Dec 29, 2023
@rohanKanojia rohanKanojia mentioned this issue Dec 29, 2023
Merged
17 tasks
@rohanKanojia rohanKanojia moved this from In Progress to Review in Eclipse JKube Dec 29, 2023
@manusa manusa added this to the 1.16.0 milestone Jan 2, 2024
@github-project-automation github-project-automation bot moved this from Review to Done in Eclipse JKube Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rohanKanojia rohanKanojia

Labels
component/helm ⎈
Projects
None yet
Milestone
1.16.0
Development

Successfully merging a pull request may close this issue.

fix (jkube-kit/resource/helm) : Helm values.yaml sorted alphabetically rohanKanojia/jkube
2 participants
@manusa @rohanKanojia