Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JKube Plugins generating resource manifests with line feeds on Windows #3007

Closed
rohanKanojia opened this issue May 2, 2024 · 0 comments · Fixed by #3008
Closed

JKube Plugins generating resource manifests with line feeds on Windows #3007

rohanKanojia opened this issue May 2, 2024 · 0 comments · Fixed by #3008
Labels
bug Something isn't working
Milestone

Comments

@rohanKanojia
Copy link
Member

Describe the bug

JKube is always generating resource manifests with Unix line endings (Line Feed). On windows it should be generating line feed for windows.

jkubelinefeedonwindows

Adding the following Jackson configuration in org.eclipse.jkube.kit.common.util.Serialization seems to fix the issue

.configure(YAMLGenerator.Feature.USE_PLATFORM_LINE_BREAKS, true)

Eclipse JKube version

SNAPSHOT

Component

Kubernetes Maven Plugin

Apache Maven version

None

Gradle version

None

Steps to reproduce

  1. Run mvn k8s:resource on Windows
  2. Check generated manifests,they would have Unix Line Feed endings instead of CRLF

Expected behavior

JKube should generate files with platform specific line endings

Runtime

minikube

Kubernetes API Server version

1.25.3

Environment

Windows

Eclipse JKube Logs

No response

Sample Reproducer Project

No response

Additional context

No response

@rohanKanojia rohanKanojia added the bug Something isn't working label May 2, 2024
@manusa manusa added this to the 1.17.0 milestone May 2, 2024
@manusa manusa moved this to Planned in Eclipse JKube May 2, 2024
@github-project-automation github-project-automation bot moved this from Planned to Done in Eclipse JKube May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants