KubernetesClientUtil : Refactor loop to get rid of nested if statements

[rohanKanojia]

Component

JKube Kit

Task description

Description

This loop in KubernetesClientUtil seems to have a lot of nested statements:

jkube/jkube-kit/config/service/src/main/java/org/eclipse/jkube/kit/config/service/kubernetes/KubernetesClientUtil.java

Lines 141 to 148 in 7d08fb0

	for (PodCondition condition : conditions) {
	String type = condition.getType();
	if (StringUtils.isNotBlank(type)) {
	if ("ready".equalsIgnoreCase(type)) {
	String statusText = condition.getStatus();
	if (StringUtils.isNotBlank(statusText)) {
	if (Boolean.parseBoolean(statusText)) {
	return type;

We should refactor it. I think we can make use of Java Stream API here to get the desired result quite easily.

Expected Behavior

Nested if statements are removed from for loop

Acceptance Criteria

• Nested if statements are removed from for loop
• Project compiles cleanly after running mvn clean install

[l3002]

Hi @rohanKanojia : I can work on this. Could you please assign this issue to me?

[rohanKanojia]

@l3002: You already have 2 issues assigned to you at the moment. It's generally advised to not work on multiple things at a time. Will you be okay with picking up this one as well (considering your existing work priorities) ?

[rohit-satya]

@rohanKanojia Please assign this to me

[rohanKanojia]

@rohit-satya : You've commented on multiple issues. Which one should I assign?

[l3002]

@rohanKanojia : I'll be delivering the a PR for #2665 today, so I'm sure I'll be able to work on this issue as well. For #2841, I will try to close this one by this week only. Therefore, If multiple issue assignation complies with the existing policy for this repo, then I'll be glad to work on this.

[manusa]

Note that we create new issues every week.

[rohit-satya]

@rohit-satya : You've commented on multiple issues. Which one should I assign?

@rohanKanojia In such a case please assign any one and you can reject me for others if you think I won't be able to deliver in time

[l3002]

Hi @rohanKanojia, Please go ahead and assign this issue to @rohit-satya, he as already created a pull request for this.

@rohit-satya: Thanks Rohit, I was quite busy last week, couldn't get to this.