Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenShiftBuildServiceUtils 'nocache.length() == 0' can be replaced with 'nocache.isEmpty()' #3235

Closed
manusa opened this issue Jul 17, 2024 · 3 comments · Fixed by #3250
Closed
Assignees
Labels
first-timers-only Is this your first time contributing? This could be a good place to start! good first issue Good for newcomers
Milestone

Comments

@manusa
Copy link
Member

manusa commented Jul 17, 2024

Description

The call to String.length can be replaced with isEmpty in OpenShiftBuildServiceUtils.

The following line:

should be changed to:

      return nocache.isEmpty() || Boolean.parseBoolean(nocache);

🔴 Before you start 🔴

👇 👇 👇 👇 👇 👇 👇 👇 👇 👇 👇 👇 👇 👇 👇 👇

Make sure you read the contributing guide first.

Pay special attention to the ECA agreement section and the requirement to sign-off your commit.

This is a first-timers-only issue. These issues are especially created for contributors who are contributing to the project for the first time.

If you have already contributed to this project in the past, please don't ask to be assigned one of these issues and look for good-first-issues or help-wanted issues instead in order to continue you contributor journey in the project.

@manusa manusa added good first issue Good for newcomers first-timers-only Is this your first time contributing? This could be a good place to start! labels Jul 17, 2024
@Priya-753
Copy link
Contributor

This is my first time contributing to this project. Can this be assigned to me?

@AhmedFaizanDev
Copy link
Contributor

can i work on this project ?

@rohanKanojia
Copy link
Member

@AhmedFaizanDev : Could you please pick some issue that's not assigned to anyone?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-timers-only Is this your first time contributing? This could be a good place to start! good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants