Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace anonymous Runnables with lambdas in WatchService #370

Closed
rohanKanojia opened this issue Aug 27, 2020 · 4 comments · Fixed by #437
Closed

Replace anonymous Runnables with lambdas in WatchService #370

rohanKanojia opened this issue Aug 27, 2020 · 4 comments · Fixed by #437
Assignees
@Shivkumar13
Labels
good first issue Good for newcomers help wanted Extra attention is needed java Pull requests that update Java code

Comments

@rohanKanojia
Copy link
Member

Description

I see that we have some places in code where we're still using anonymous classes. Since we're already on Java 8, we can easily refactor these to make use of lambdas. For example, I noticed these in WatchService:

https://github.com/eclipse/jkube/blob/8ca3f342372128fe12ea1572db1e37d033406a94/jkube-kit/build/service/docker/src/main/java/org/eclipse/jkube/kit/build/service/docker/WatchService.java#L141-L156

https://github.com/eclipse/jkube/blob/8ca3f342372128fe12ea1572db1e37d033406a94/jkube-kit/build/service/docker/src/main/java/org/eclipse/jkube/kit/build/service/docker/WatchService.java#L179-L201

https://github.com/eclipse/jkube/blob/8ca3f342372128fe12ea1572db1e37d033406a94/jkube-kit/build/service/docker/src/main/java/org/eclipse/jkube/kit/build/service/docker/WatchService.java#L211-L223
@rohanKanojia rohanKanojia added good first issue Good for newcomers help wanted Extra attention is needed java Pull requests that update Java code labels Aug 27, 2020
@Shivkumar13
Copy link
Contributor

/assign

@rohanKanojia
Copy link
Member Author

@Shivkumar13 : Hi, are you still working on this issue?

@Shivkumar13
Copy link
Contributor

Shivkumar13 commented Sep 14, 2020 •
edited
Loading

@rohanKanojia apologies for the delay, I will update my findings in a day.

@Shivkumar13 Shivkumar13 mentioned this issue Oct 17, 2020
Merged
12 tasks
@ghost
Copy link

ghost commented Feb 1, 2023

Hello sir ,
I am new to open source contribution.
I already know java , my tech stacks & tools includes C, C++ , Python , Java, JavaScript , HTML , CSS , SQL , Bootstrap, ReactJS, ExpressJS, NodeJS & Git . I need a little help from your side to contribute to these amazing projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Shivkumar13 Shivkumar13

Labels
good first issue Good for newcomers help wanted Extra attention is needed java Pull requests that update Java code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replacing anonymous Runnables with lambdas in WatchService Shivkumar13/jkube
2 participants
@rohanKanojia @Shivkumar13