-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #3286: Replace deprecated asList() in Web App Generator Test #3302
Merged
manusa
merged 3 commits into
eclipse-jkube:master
from
ShivamChavan01:issue-3286-replace-deprecated-aslist-in-web-app-generator-test
Aug 7, 2024
Merged
Issue #3286: Replace deprecated asList() in Web App Generator Test #3302
manusa
merged 3 commits into
eclipse-jkube:master
from
ShivamChavan01:issue-3286-replace-deprecated-aslist-in-web-app-generator-test
Aug 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShivamChavan01
requested review from
manusa,
rohanKanojia and
sunix
as code owners
August 4, 2024 10:13
Eclipse JKube CI ReportStarted new GH workflow run for #3302 (2024-08-07T04:46:57Z) ⚙️ JKube E2E Tests (10278169511)
|
rohanKanojia
reviewed
Aug 5, 2024
...t/generator/webapp/src/test/java/org/eclipse/jkube/generator/webapp/WebAppGeneratorTest.java
Outdated
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
rohanKanojia
approved these changes
Aug 7, 2024
manusa
approved these changes
Aug 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx!
ShivamChavan01
deleted the
issue-3286-replace-deprecated-aslist-in-web-app-generator-test
branch
September 27, 2024 13:58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3286
Replace deprecated asList() in Web App Generator Test
Type of change
test, version modification, documentation, etc.)
Checklist