-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename master > main #1919
Rename master > main #1919
Conversation
@HannesWell @merks can you probabbly look at the setup files if I did adjusted them correctly? |
Test Results 321 files 321 suites 52m 41s ⏱️ For more details on these errors, see this check. Results for commit 4050a39. ♻️ This comment has been updated with latest results. |
Looks ok. It will effectively disable the project setup reference in existing workspace.setup, i.e., existing installations will no longer see or use the project setup. |
d9e4cca
to
70d4883
Compare
581f192
to
ac10392
Compare
@HannesWell it seems that changing the markdown file generates a version bump, I tried to fix that for the future but the configuration looks odd, it tells it wants pom.xml changes (but why?!?) and disables all jgit ignores... confusing. Another way would maybe to just move the markdown to the root... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HannesWell it seems that changing the markdown file generates a version bump, I tried to fix that for the future but the configuration looks odd, it tells it wants pom.xml changes (but why?!?) and disables all jgit ignores... confusing.
In case of the lemminx-bundle the inclusion is of the embedded lemminx jar is driven by the pom.xml file. And in case the lemminx version is changed in this pom we want to have a an updated qualifier.
However I don't see in the parent (anymore) that pom.xml files are generally excluded. Maybe that's from the past.
But should not the embedded jar itself already make a difference? |
Signed-off-by: Christoph Läubrich <[email protected]>
ac10392
to
4050a39
Compare
Further refinements can better be made in separate PRs. |
The jar is not committed into the repository, it's just copied into the project by the build. Therefore a change in the jar itself doesn't change the git-timestamp. |
No description provided.