Add override to virtual methods of TR_J9SharedCache and TR_J9VMBase #20710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Despres <[email protected]>
Signed-off-by: Christian Despres <[email protected]>
|
Attn @mpirvu. A few times now I've changed something in these classes in a way that conflicts with the base classes. This will at least provide some warning when I do that. |
mpirvu
approved these changes
Nov 29, 2024
|
jenkins compile all jdk8,jdk23 |
Those are the only methods that are actually overridden from the base classes. The rest are declared for the first time in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These overrides are helpful when changing the interfaces of classes, so that warnings (at least in clang) are generated if the methods of the base classes aren't changed to compensate.