Notify dependency table at method queue time #20711
Open
+5
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Attn @mpirvu. |
mpirvu
reviewed
Nov 29, 2024
Currently, methods with unsatisfied dependencies may still have loads attempted for them. This can happen if their counts reach zero very quickly. Since this is the case, methods that are about to be queued for compilation no longer need to be tracked in the method dependency table. Signed-off-by: Christian Despres <[email protected]>
cjjdespres
force-pushed
the
notify-earlier
branch
from
cc33de3
to
9d4c253
Compare
|
I think it might be redundant - do you know of any compilations that don't go through I've removed it for now. |
mpirvu
approved these changes
Nov 29, 2024
I think that all compilation requests come from the queue. We no longer support compilation on application threads. |
|
jenkins test sanity all jdk17 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, methods with unsatisfied dependencies may still have loads attempted for them. This can happen if their counts reach zero very quickly. Since this is the case, methods that are about to be queued for compilation no longer need to be tracked in the method dependency table.