[JDK21] Add support for JVMTI ForceEarlyReturn #17874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, ForceEarlyReturn returned JVMTI_ERROR_OPAQUE_FRAME for a virtual thread. In JDK21, ForceEarlyReturn includes support for virtual threads as per the JVMTI specification: - Error if a virtual thread is not suspended and not the current thread. - Error if a virtual thread is unmounted since it won't be able to force an early return. - For a carrier thread with a virtual thread mounted, the details of the carrier thread are derived from targetThread->currentContinuation. Also, there is no need to halt and resume a thread for inspection since ForceEarlyReturn expects the thread to be suspended as per the JVMTI spec. If a thread is not suspended, it returns JVMTI_ERROR_THREAD_NOT_SUSPENDED. Related: eclipse-openj9#17713 Signed-off-by: Babneet Singh <[email protected]>
babsingh
force-pushed
the
jdk21support_jvmtiForceEarlyReturn
branch
from
043f8d1 to
dbaf246
Compare
|
Verified locally that ForceEarlyReturnTest passes with the changes from this PR. @tajila Requesting your review. This PR is identical to #17809, which you had reviewed earlier.
The above requirement to suspend is enforced from JDK8 to JDK21: JDK8 - https://docs.oracle.com/javase/8/docs/platform/jvmti/jvmti.html#ForceEarlyReturn |
|
jenkins test sanity,extended alinux64 jdk21 |
|
jenkins compile win jdk11 |
babsingh
added a commit
to babsingh/aqa-tests
that referenced
this pull request
Jul 28, 2023
eclipse-openj9/openj9#17874 fixes ForceEarlyReturnTest. Closes eclipse-openj9/openj9#17713 Signed-off-by: Babneet Singh <[email protected]>
llxia
pushed a commit
to adoptium/aqa-tests
that referenced
this pull request
Jul 28, 2023
eclipse-openj9/openj9#17874 fixes ForceEarlyReturnTest. Closes eclipse-openj9/openj9#17713 Signed-off-by: Babneet Singh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, ForceEarlyReturn returned JVMTI_ERROR_OPAQUE_FRAME for a
virtual thread.
In JDK21, ForceEarlyReturn includes support for virtual threads as
per the JVMTI specification:
thread.
force an early return.
the carrier thread are derived from targetThread->currentContinuation.
Also, there is no need to halt and resume a thread for inspection since
ForceEarlyReturn expects the thread to be suspended as per the JVMTI
spec. If a thread is not suspended,
it returns JVMTI_ERROR_THREAD_NOT_SUSPENDED.
Related: #17713