Change Attachment.loadAgentLibrary() to a static method #17919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonFengJ9
force-pushed
the
staticnative
branch
from
5367ada to
064a5c7
Compare
JasonFengJ9
changed the title
gacholio
reviewed
Aug 8, 2023
jcl/src/java.base/share/classes/openj9/internal/tools/attach/target/Attachment.java
Outdated
Show resolved
Hide resolved
gacholio
approved these changes
Aug 8, 2023
|
jenkins test sanity zlinux jdk8,jdk17 |
|
Please fix the spacing issue after testing completes and I'll merge without re-test. |
Added a dummy arg for the native loadAgentLibraryImpl() to ensure that the current native method has the ClassLoader instance as its second argument required by jnimisc.cpp:getCurrentClassLoader(). Signed-off-by: Jason Feng <[email protected]>
JasonFengJ9
force-pushed
the
staticnative
branch
from
064a5c7 to
5efd1ae
Compare
|
PR build link - https://openj9-jenkins.osuosl.org/job/PullRequest-OpenJ9/4199/ |
keithc-ca
reviewed
Aug 9, 2023
jcl/src/java.base/share/classes/openj9/internal/tools/attach/target/Attachment.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
Attachment.loadAgentLibrary()to a public static methodAdded a dummy arg for the native loadAgentLibraryImpl() to ensure that the current native method has the ClassLoader instance as its second argument required by
jnimisc.cpp:getCurrentClassLoader().related to
Signed-off-by: Jason Feng [email protected]