Add flag isVirtualLargeObjectHeapEnabled in J9VMThread and J9JavaVM #20503
Conversation
LinHu2016
commented
Nov 4, 2024
LinHu2016
commented
- cache flag isVirtualLargeObjectHeapEnabled in both J9VMThread and J9JavaVM.
- initialize both isVirtualLargeObjectHeapEnabled flags.
- cache flag isVirtualLargeObjectHeapEnabled in both J9VMThread and J9JavaVM. - initialize both isVirtualLargeObjectHeapEnabled flags. Signed-off-by: lhu <[email protected]>
|
@amicic @dmitripivkine please review the changes, Thanks |
| @@ -5480,6 +5480,7 @@ typedef struct J9VMThread { | |||
| UDATA discontiguousIndexableHeaderSize; | |||
| #if defined(J9VM_ENV_DATA64) | |||
| UDATA isIndexableDataAddrPresent; | |||
| BOOLEAN isVirtualLargeObjectHeapEnabled; | |||
There was a problem hiding this comment.
we could have this flag under the matching compile time flag, which would mean that appropriate access macros that we later introduce would be under the same flag.
@dmitripivkine, opinion, do we want it?
There was a problem hiding this comment.
after some discussion, seems like call sites (array access macros) will be a bit more complex and harder to read (and they are already hard to read), with little benefit (one less field in VM Thread, if build flag is disabled, which would be interesting only for 32bit platforms in some exceptional build specs)
so let's leave it as-is, but we can always add it later if we want
There was a problem hiding this comment.
With the addition of this field, should line 5517 change?
#if 0 && !defined(J9VM_ENV_DATA64) /* Change to 0 or 1 based on number of fields above */
FYI @gacholio
There was a problem hiding this comment.
We should add an assertion into the build process to detect this,
There was a problem hiding this comment.
Was the alignment resolved?
There was a problem hiding this comment.
Seems like that line should be updated only for non 64 bit platforms, and we added a field for 64 bit only.
There was a problem hiding this comment.
Yes, I see that now. I still think @gacholio's suggestion to have a build-time check is a good one.
|
jenkins compile aix jdk8 |
