Update macros J9JAVAARRAYCONTIGUOUS_EA for off heap #20565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Macro J9JAVAARRAYCONTIGUOUS_EA and J9JAVAARRAYCONTIGUOUS_EA_VM
to handle all the cases(IndexableDataAddrPresent/or not and
VirtualLargeObjectHeapEnabled/or not).
if IndexableDataAddrPresent
if VirtualLargeObjectHeapEnabled
J9JAVAARRAYCONTIGUOUS_WITH_DATAADDRESS_VIRTUALLARGEOBJECTHEAPENABLED
else
J9JAVAARRAYCONTIGUOUS_WITH_DATAADDRESS_VIRTUALLARGEOBJECTHEAPDISABLED
else
J9JAVAARRAYCONTIGUOUS_WITHOUT_DATAADDRESS
Signed-off-by: lhu <[email protected]>
|
@amicic @dmitripivkine Could you please review the changes, Thanks |
|
we might not want to deliver this too early since it will cause small regression to standard GCs interpreter perf, due to extra is-present check |
amicic
reviewed
Nov 12, 2024
| ? (&((elemType*)((((J9IndexableObjectContiguousCompressed *)(array)) + 1)))[index]) \ | ||
| : (&((elemType*)((((J9IndexableObjectContiguousFull *)(array)) + 1)))[index])) | ||
|
|
||
| #define J9JAVAARRAYCONTIGUOUS_WITHOUT_DATAADDRESS_EA_VM(javaVM, array, index, elemType) \ |
There was a problem hiding this comment.
I don't like the fact that there is a reference to DATAADDRESS outside of appropriate build flag
and there are 2 issues:
- DATAADDRESS is outside of J9VM_ENV_DATA64
- the build flag should really be JVM_GC_SPARSE_HEAP_ALLOCATION (not J9VM_ENV_DATA64)
I'll think if we can reshuffle cleanly
There was a problem hiding this comment.
perhpas the simplest is to use BASE (or some other generic term) rather than WITHOUT_DATAADDRESS
@dmitripivkine, opinion?
for using the proper build flag, as we discussed recently, let's don't change it yet #20503 (comment)
There was a problem hiding this comment.
yes, we can use BASE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Macro J9JAVAARRAYCONTIGUOUS_EA and J9JAVAARRAYCONTIGUOUS_EA_VM to handle all the cases(IndexableDataAddrPresent/or not and VirtualLargeObjectHeapEnabled/or not).
if IndexableDataAddrPresent
if VirtualLargeObjectHeapEnabled
J9JAVAARRAYCONTIGUOUS_WITH_DATAADDRESS_VIRTUALLARGEOBJECTHEAPENABLED
else
J9JAVAARRAYCONTIGUOUS_WITH_DATAADDRESS_VIRTUALLARGEOBJECTHEAPDISABLED
else
J9JAVAARRAYCONTIGUOUS_WITHOUT_DATAADDRESS