Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No support for ALPN #858

Open
3 tasks done
timmattison opened this issue Jan 20, 2021 · 5 comments
Open
3 tasks done

No support for ALPN #858

timmattison opened this issue Jan 20, 2021 · 5 comments

Comments

@timmattison
Copy link

Paho doesn't currently allow the use of ALPN. This can be fixed in the SSLNetworkModule class. I will submit a PR for it.

  • Bug exists Release Version 1.2.5 ( Master Branch)
  • Bug exists in MQTTv3 Client on Snapshot Version 1.2.6-SNAPSHOT (Develop Branch)
  • Bug exists in MQTTv5 Client on Snapshot Version 1.2.6-SNAPSHOT (Develop Branch)
@timmattison
Copy link
Author

This is necessary to connect to AWS IoT on port 443.

@timmattison
Copy link
Author

On further review this appears to be quite involved to get working. The PR may take longer than expected. Has this been requested before?

@fpagliughi
Copy link

This was recently added to the Paho C library (and then the C++ and Rust libraries got it for "free"). But I haven't seen a request for the Java library yet.

@timmattison
Copy link
Author

Yeah, this would be very helpful to connect to AWS IoT. Unfortunately it looks like it's beyond the level of effort I can expend for the time I was going to commit to it.

Is there any way to get this prioritized so Java has feature parity with C/C++/Rust?

@grandfield
Copy link
Contributor

@timmattison Instead of adding ALPN support, do you think it would be appropriate to fix what caused it to break in the first place? See pull request #942
I'm a newbie to paho, but something along these lines would be lower maintenance for PAHO. You are free to then add the aws alpn into the socket factory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants