Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ASM in Sisu to 9.2 (Bugzilla Bug 546874) #29

Closed
mcculls opened this issue Oct 25, 2021 · 1 comment · Fixed by #34
Closed

Upgrade ASM in Sisu to 9.2 (Bugzilla Bug 546874) #29

mcculls opened this issue Oct 25, 2021 · 1 comment · Fixed by #34
Labels
bug Something isn't working
Milestone

Comments

@mcculls
Copy link
Contributor

mcculls commented Oct 25, 2021

This issue was created automatically with bugzilla2github

Bugzilla Bug 546874

Date: 2019-04-30 13:35:25 -0400
From: Robert Scholte <[email protected]>
To: Stuart McCulloch <[email protected]>
CC: [email protected]

Last updated: 2019-11-05 19:10:55 -0500

Comment 3034851

Date: 2019-04-30 13:35:25 -0400
From: Robert Scholte <[email protected]>

According to https://issues.apache.org/jira/browse/MNG-6580 Sisu is not capable in scanning Java class files with target/release 9+ due to an old version of ASM.
I've marked it as critical since there's no workaround (other than staying on a n older Java version).

Comment 3093146

Date: 2019-11-05 19:10:55 -0500
From: Stuart McCulloch <[email protected]>

I've put a small workaround in the 0.3.4 release which means the scanner now attempts to scan bytecode up to and including the Java 14 level. This was possible because the scanner only does a light scan of the class file and isn't affected by recent bytecode additions.

I'll leave this ticket open as I still want to get master onto the latest ASM release.

@mcculls mcculls added bug Something isn't working major and removed major labels Oct 25, 2021
@bentmann
Copy link
Contributor

Getting Sisu on a newer ASM version to play nice with current Java versions would be really nice.

@mcculls mcculls changed the title Upgrade ASM in Sisu to 7.1 (Bugzilla Bug 546874) Upgrade ASM in Sisu to 9.2 (Bugzilla Bug 546874) Oct 29, 2021
@mcculls mcculls added this to the 0.9.0.M1 milestone May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants