From 3fa21816eefdb91176651a1557ddf2c8f68a4227 Mon Sep 17 00:00:00 2001 From: Marc Dumais Date: Thu, 23 Feb 2023 15:15:23 -0500 Subject: [PATCH] [builtins] Use vscode builtin extensions v1.70.2 Some time between 1.66.2 and 1.70.2, the references-view extension "ms-vscode.references-view" has gone from a standalone extension, that has its own repository, to a vscode built-in extension, that's part of the vscode repository. With that change, the extension's publisher has been updated from "ms-vscode" to "vscode". As of 1.70.2, this extension is referenced in the builtins extension pack and no longer needs to be specifically referenced in `package.json`. This PR contains the following: - example application: update the builtin extension pack to v1.70.2, remove entry for old `references-view` extension and remove pinning for typescript extensions. - typescript browser tests: use new name to reference `references-view` extension Signed-off-by: Marc Dumais --- examples/api-tests/src/typescript.spec.js | 2 +- package.json | 5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/examples/api-tests/src/typescript.spec.js b/examples/api-tests/src/typescript.spec.js index de17449796150..cc3044369ca28 100644 --- a/examples/api-tests/src/typescript.spec.js +++ b/examples/api-tests/src/typescript.spec.js @@ -57,7 +57,7 @@ describe('TypeScript', function () { const pluginViewRegistry = container.get(PluginViewRegistry); const typescriptPluginId = 'vscode.typescript-language-features'; - const referencesPluginId = 'ms-vscode.references-view'; + const referencesPluginId = 'vscode.references-view'; const eslintPluginId = 'dbaeumer.vscode-eslint'; /** @type Uri.URI */ const rootUri = workspaceService.tryGetRoots()[0].resource; diff --git a/package.json b/package.json index ac9a632d8f02b..7f499f08789b8 100644 --- a/package.json +++ b/package.json @@ -100,10 +100,9 @@ "theiaPluginsDir": "plugins", "theiaPlugins": { "vscode.markdown-language-features": "https://open-vsx.org/api/vscode/markdown-language-features/1.64.2/file/vscode.markdown-language-features-1.64.2.vsix", - "eclipse-theia.builtin-extension-pack": "https://open-vsx.org/api/eclipse-theia/builtin-extension-pack/1.66.2/file/eclipse-theia.builtin-extension-pack-1.66.2.vsix", + "eclipse-theia.builtin-extension-pack": "https://open-vsx.org/api/eclipse-theia/builtin-extension-pack/1.70.2/file/eclipse-theia.builtin-extension-pack-1.70.2.vsix", "EditorConfig.EditorConfig": "https://open-vsx.org/api/EditorConfig/EditorConfig/0.14.4/file/EditorConfig.EditorConfig-0.14.4.vsix", - "dbaeumer.vscode-eslint": "https://open-vsx.org/api/dbaeumer/vscode-eslint/2.1.20/file/dbaeumer.vscode-eslint-2.1.20.vsix", - "ms-vscode.references-view": "https://open-vsx.org/api/ms-vscode/references-view/0.0.89/file/ms-vscode.references-view-0.0.89.vsix" + "dbaeumer.vscode-eslint": "https://open-vsx.org/api/dbaeumer/vscode-eslint/2.1.20/file/dbaeumer.vscode-eslint-2.1.20.vsix" }, "theiaPluginsExcludeIds": [ "ms-vscode.js-debug-companion",