Review comments

eclipse-theia · May 7, 2024 · 711fb31 · 711fb31
1 parent 6369f6f
commit 711fb31
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/packages/notebook/src/browser/view-model/notebook-model.ts b/packages/notebook/src/browser/view-model/notebook-model.ts
@@ -187,7 +187,7 @@ export class NotebookModel implements Saveable, Disposable {
             throw new Error('could not read notebook snapshot');
         }
         const data = JSON.parse(rawData) as NotebookData;
-        this.reset(data);
+        this.setData(data);
     }
 
     async revert(options?: Saveable.RevertOptions): Promise<void> {
@@ -212,7 +212,7 @@ export class NotebookModel implements Saveable, Disposable {
         }
     }
 
-    reset(data: NotebookData): void {
+    setData(data: NotebookData): void {
         // Replace all cells in the model
         this.replaceCells(0, this.cells.length, data.cells, false);
         this.metadata = data.metadata;

diff --git a/packages/plugin-ext/src/main/browser/notebooks/notebook-documents-main.ts b/packages/plugin-ext/src/main/browser/notebooks/notebook-documents-main.ts
@@ -162,7 +162,7 @@ export class NotebookDocumentsMainImpl implements NotebookDocumentsMain {
         // apply content changes... slightly HACKY -> this triggers a change event
         if (options.content) {
             const data = NotebookDto.fromNotebookDataDto(options.content);
-            ref.reset(data);
+            ref.setData(data);
         }
         return ref.uri.toComponents();
     }