address review comment:

- move preferences to right location - remove unused code - remove confusing Test Explorer preference
eclipse-theia · Jun 26, 2024 · 7ff7879 · 7ff7879
1 parent 5d98e70
commit 7ff7879
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 20 deletions.
diff --git a/packages/preferences/src/browser/util/preference-tree-generator.ts b/packages/preferences/src/browser/util/preference-tree-generator.ts
@@ -67,6 +67,7 @@ export class PreferenceTreeGenerator {
         ['search', 'features'],
         ['task', 'features'],
         ['terminal', 'features'],
+        ['testing', 'features'],
         ['toolbar', 'features'],
         ['webview', 'features'],
         ['workspace', 'application'],

diff --git a/packages/test/src/browser/test-execution-progress-service.ts b/packages/test/src/browser/test-execution-progress-service.ts
@@ -15,9 +15,8 @@
 // *****************************************************************************
 
 import { inject, injectable } from '@theia/core/shared/inversify';
-import { ApplicationShell, Widget, WidgetManager } from '@theia/core/lib/browser';
+import { Widget } from '@theia/core/lib/browser';
 import { TestResultViewContribution } from './view/test-result-view-contribution';
-import { TestService } from './test-service';
 import { TestViewContribution } from './view/test-view-contribution';
 import { TestPreferences } from './test-preferences';
 
@@ -30,21 +29,12 @@ export const TestExecutionProgressService = Symbol('TestExecutionProgressService
 @injectable()
 export class DefaultTestExecutionProgressService implements TestExecutionProgressService {
 
-    @inject(WidgetManager)
-    protected readonly widgetManager: WidgetManager;
-
-    @inject(ApplicationShell)
-    protected readonly shell: ApplicationShell;
-
     @inject(TestResultViewContribution)
     protected readonly testResultView: TestResultViewContribution;
 
     @inject(TestViewContribution)
     protected readonly testView: TestViewContribution;
 
-    @inject(TestService)
-    protected readonly testService: TestService;
-
     @inject(TestPreferences)
     protected readonly testPreferences: TestPreferences;
 
@@ -53,17 +43,11 @@ export class DefaultTestExecutionProgressService implements TestExecutionProgres
             const openTesting = this.testPreferences['testing.openTesting'];
             if (openTesting === 'openOnTestStart') {
                 this.openTestResultView();
-            } else if (openTesting === 'openExplorerOnTestStart') {
-                this.openTestExplorerView();
             }
         }
     }
 
     async openTestResultView(): Promise<Widget> {
         return this.testResultView.openView({ activate: true });
     }
-
-    async openTestExplorerView(): Promise<Widget> {
-        return this.testView.openView({ activate: true });
-    }
 }
diff --git a/packages/test/src/browser/test-preferences.ts b/packages/test/src/browser/test-preferences.ts
@@ -23,11 +23,10 @@ export const TestConfigSchema: PreferenceSchema = {
     properties: {
         'testing.openTesting': {
             type: 'string',
-            enum: ['neverOpen', 'openOnTestStart', 'openExplorerOnTestStart'],
+            enum: ['neverOpen', 'openOnTestStart'],
             enumDescriptions: [
                 nls.localizeByDefault('Never automatically open the testing views'),
                 nls.localizeByDefault('Open the test results view when tests start'),
-                nls.localizeByDefault('Open the test explorer when tests start'),
             ],
             description: nls.localizeByDefault('Controls when the testing view should open.'),
             default: 'neverOpen',
@@ -37,7 +36,7 @@ export const TestConfigSchema: PreferenceSchema = {
 };
 
 export interface TestConfiguration {
-    'testing.openTesting': 'neverOpen' | 'openOnTestStart' | 'openExplorerOnTestStart';
+    'testing.openTesting': 'neverOpen' | 'openOnTestStart';
 }
 
 export const TestPreferenceContribution = Symbol('TestPreferenceContribution');