Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin: add proper support for appRoot #11477

Closed
vince-fugnitto opened this issue Jul 28, 2022 · 0 comments · Fixed by #13285
Closed

plugin: add proper support for appRoot #11477

vince-fugnitto opened this issue Jul 28, 2022 · 0 comments · Fixed by #13285
Labels
vscode issues related to VSCode compatibility
Milestone

Comments

@vince-fugnitto
Copy link
Member

vince-fugnitto commented Jul 28, 2022

Bug Description:

The vscode.env.appRoot is not properly implemented (likely stubbed initially) and should be updated:

/**
* Provides application root.
*/
get appRoot(): string {
return __dirname;
}

This means that that file's parent directory will be marked as the appRoot:

image

Steps to Reproduce:

  1. include the following test extension (vscode-approot-0.0.1.zip)

  2. start the application

  3. execute the command Env: App Root

@vince-fugnitto vince-fugnitto added the vscode issues related to VSCode compatibility label Jul 28, 2022
@jfaltermeier jfaltermeier added this to the 1.46.0 milestone Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants