-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't fix/skip the ffmpeg codec problem #11822
Comments
@ouliuquan I don't believe that
The |
@vince-fugnitto Thanks for that, I am studying this framework, hope we can make theia better. And if we do replace codec, we can do it better without error, or just skip the check. |
@ouliuquan by the way, there does not seem to be errors in your output, least of which from the replace and check of
We can see from the output that the replacement worked (used cached version likely since you already did the replacement earlier), and that the check passes as no proprietary codecs are found. If you are referring to these warnings, they do not affect the build and are unrelated to
As you can tell the build is still successful which would otherwise not be possible if they were actual errors. |
@vince-fugnitto I know that had been replaced. |
@ouliuquan I don't know any strong reasons to skip replacing the proprietary codecs for legal reasons, but I assume the flag would need to be re-added, or you can customize how the electron is prepared by inspiring yourself from |
@vince-fugnitto Thanks for your advise, I know how to do what I want now. By removing the code will skip ffmpeg codec check:
This issue will be closed soon. |
Bug Description:
I try to use the
THEIA_ELECTRON_SKIP_REPLACE_FFMPEG=1 yarn
to avoid download/replace ffmpeg module, but it doesn't work.Can we set the ffmpeg option default to false/0? This real confused newcomer.
Steps to Reproduce:
THEIA_ELECTRON_SKIP_REPLACE_FFMPEG=1 yarn
Error log:
Additional Information
The text was updated successfully, but these errors were encountered: